feat(deployment): Upload of artifacts should be retried on failure

Close #1749
electron-userland · Jul 3, 2017 · 7ffcd27 · 7ffcd27
1 parent 6ed59be
commit 7ffcd27
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.idea/dictionaries/develar.xml b/.idea/dictionaries/develar.xml
diff --git a/packages/electron-publish/src/BintrayPublisher.ts b/packages/electron-publish/src/BintrayPublisher.ts
@@ -61,7 +61,7 @@ export class BintrayPublisher extends HttpPublisher {
       return
     }
 
-    let badGatewayCount = 0
+    let attemptNumber = 0
     for (let i = 0; i < 3; i++) {
       try {
         return await httpExecutor.doApiRequest<any>(configureRequestOptions({
@@ -76,7 +76,7 @@ export class BintrayPublisher extends HttpPublisher {
         }, this.client.auth), this.context.cancellationToken, requestProcessor)
       }
       catch (e) {
-        if (e instanceof HttpError && e.response.statusCode === 502 && badGatewayCount++ < 3) {
+        if (attemptNumber++ < 3 && ((e instanceof HttpError && e.response.statusCode === 502) || e.code === "EPIPE")) {
           continue
         }
 

diff --git a/packages/electron-publish/src/gitHubPublisher.ts b/packages/electron-publish/src/gitHubPublisher.ts
@@ -107,7 +107,7 @@ export class GitHubPublisher extends HttpPublisher {
     }
 
     const parsedUrl = parseUrl(release.upload_url.substring(0, release.upload_url.indexOf("{")) + "?name=" + fileName)
-    let badGatewayCount = 0
+    let attemptNumber = 0
     uploadAttempt: for (let i = 0; i < 3; i++) {
       try {
         return await httpExecutor.doApiRequest<any>(configureRequestOptions({
@@ -138,10 +138,13 @@ export class GitHubPublisher extends HttpPublisher {
             debug(`Artifact ${fileName} not found on GitHub, trying to upload again`)
             continue
           }
-          else if (e.response.statusCode === 502 && badGatewayCount++ < 3) {
+          else if (attemptNumber++ < 3 && e.response.statusCode === 502) {
             continue
           }
         }
+        else if (attemptNumber++ < 3 && e.code === "EPIPE") {
+          continue
+        }
 
         throw e
       }