fix(windows): disable feature "sign dlls" by default

electron-userland · Jul 11, 2018 · f474ecb · f474ecb
1 parent 5503cee
commit f474ecb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/electron-builder-lib/src/options/winOptions.ts b/packages/electron-builder-lib/src/options/winOptions.ts
@@ -94,6 +94,13 @@ export interface WindowsConfiguration extends PlatformSpecificBuildOptions {
    */
   readonly signAndEditExecutable?: boolean
 
+  /**
+   * Whether to sign DLL files. Advanced option.
+   * @see https://github.com/electron-userland/electron-builder/issues/3101#issuecomment-404212384
+   * @default false
+   */
+  readonly signDlls?: boolean
+
   /**
    * The electron-updater compatibility semver range. e.g. `>= 2.16`, `>=1.0.0`. Defaults to `>=1.0.0`
    *

diff --git a/packages/electron-builder-lib/src/winPackager.ts b/packages/electron-builder-lib/src/winPackager.ts
@@ -340,13 +340,17 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
     }
   }
 
+  private isSignDlls(): boolean {
+    return this.platformSpecificBuildOptions.signDlls === true
+  }
+
   protected createTransformerForExtraFiles(packContext: AfterPackContext): FileTransformer | null {
     if (this.platformSpecificBuildOptions.signAndEditExecutable === false) {
       return null
     }
 
     return file => {
-      if (file.endsWith(".exe") || file.endsWith(".dll")) {
+      if (file.endsWith(".exe") || (this.isSignDlls() && file.endsWith(".dll"))) {
         const parentDir = path.dirname(file)
         if (parentDir !== packContext.appOutDir) {
           return new CopyFileTransformer(file => this.sign(file))
@@ -366,7 +370,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
       if (file === exeFileName) {
         return this.signAndEditResources(path.join(packContext.appOutDir, exeFileName), packContext.arch, packContext.outDir, path.basename(exeFileName, ".exe"), this.platformSpecificBuildOptions.requestedExecutionLevel)
       }
-      else if (file.endsWith(".exe") || file.endsWith(".dll")) {
+      else if (file.endsWith(".exe") || (this.isSignDlls() && file.endsWith(".dll"))) {
         return this.sign(path.join(packContext.appOutDir, file))
       }
       return null