Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vPrefixedTagName for auto update #1417

Closed
alexbrazier opened this issue Mar 29, 2017 · 3 comments · May be fixed by qcif/data-curator#563
Closed

Add vPrefixedTagName for auto update #1417

alexbrazier opened this issue Mar 29, 2017 · 3 comments · May be fixed by qcif/data-curator#563

Comments

@alexbrazier
Copy link
Contributor

alexbrazier commented Mar 29, 2017

  • Cersion: 16.4.2
  • Target: macOS

The publish option vPrefixedTagName should be added for auto update as the the latest-mac.json file and the auto update request to get the latest version will always assume that the url is v1.0.0 instead of just 1.0.0, causing errors if you don't tag releases starting with a v

@develar
Copy link
Member

develar commented Mar 29, 2017

We write publish config as is, so, vPrefixedTagName is already available for GitHubProvider.

But! Due to Squirrel.Mac limitation we have to build url in-advancebuild-time. So computeDownloadUrl should be fixed.

Done — will be released in 10 minutes.

@alexbrazier
Copy link
Contributor Author

Awesome, thanks for the quick fix.
There also appears to be an issue with GitHubProvider.ts in a couple of places where the url is hardcoded with a v e.g. https://github.com${basePath}/download/v${versionInfo.version}/${name}, is it possible to use the vPrefixedTagName tag name for this as well?

@develar
Copy link
Member

develar commented Mar 29, 2017

is it possible to use the vPrefixedTagName tag name for this as well?

Yes, you are right, it is a part of fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants