Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ko" is not a valid language id when including license_ko.rtf #1504

Closed
timfish opened this issue Apr 26, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Closed

"ko" is not a valid language id when including license_ko.rtf #1504

timfish opened this issue Apr 26, 2017 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@timfish
Copy link
Contributor

timfish commented Apr 26, 2017

Version: [email protected]
Building For nsis

With the following config

    "nsis": {
      "guid": "xxxxx-xxxxx-xxxxxx-xxxxx",
      "include": "resources/installer.nsh",
      "multiLanguageInstaller": true,
      "oneClick": false,
      "perMachine": true,
      "allowToChangeInstallationDirectory": true,
      "menuCategory": true
    }

installer.nsh

!macro customInstall
  ExecWait '"$INSTDIR\resources\DPInst.exe" /sw'
!macroend

And I'm including the following license_*.rtf files:

image

And seeing the following error:

Processing script file: "<stdin>" (ACP)
warning: "ko" is not a valid language id, using language id 1041! (macro:licensePage:7)

Error output:
Error: warning treated as error

NSIS script:
!addincludedir "C:\Users\tim\Documents\Repos\app-workingcopy\node_modules\electron-builder\templates\nsis\include"
!addplugindir /x86-unicode "C:\Users\tim\AppData\Local\electron-builder\cache\nsis-resources\nsis-resources-3.0.0\plugins\x86-unicode"
!addplugindir /x86-unicode "C:\Users\tim\Documents\Repos\app-workingcopy\resources\x86-unicode"

!macro licensePage
  LicenseLangString MUILicense 1033 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1031 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_de.rtf"
  LicenseLangString MUILicense 3082 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_es.rtf"
  LicenseLangString MUILicense 1036 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_fr.rtf"
  LicenseLangString MUILicense 1040 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_it.rtf"
  LicenseLangString MUILicense 1041 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_ja.rtf"
  LicenseLangString MUILicense ko "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_ko.rtf"
  LicenseLangString MUILicense 1028 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_zh.rtf"
  LicenseLangString MUILicense 2052 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1043 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1049 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1045 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1058 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1029 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1053 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1044 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 1030 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  LicenseLangString MUILicense 2070 "C:\Users\tim\Documents\Repos\app-workingcopy\resources\license_en.rtf"
  !insertmacro MUI_PAGE_LICENSE "$(MUILicense)"
!macroend
!include "C:\Users\tim\AppData\Local\Temp\electron-builder-YnvXD2\0-5-messages.nsh"
!include "C:\Users\tim\AppData\Local\Temp\electron-builder-YnvXD2\0-4-messages.nsh"
!addincludedir "C:\Users\tim\Documents\Repos\app-workingcopy\resources"
!include "C:\Users\tim\Documents\Repos\app-workingcopy\resources\installer.nsh"

Which is very strange when its listed here.

@develar
Copy link
Member

develar commented May 13, 2017

Korean lang is bundled now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants