Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows (Squirrel) Start Menu Category Won't Change from Email Address #2024

Closed
framerate opened this issue Sep 1, 2017 · 13 comments
Closed
Labels

Comments

@framerate
Copy link

  • 19.27.2:
  • Windows:
    "win": {
            "icon": "build/icon.ico",
            "target": "squirrel",
            "publisherName": "Secret Cow Level"
        },

I thought by reading the documentation that publisherName was what I was missing, but no matter what I do, it seems to use my email from package.json -> author field? I don't want my email to be the Start Menu Category.

What am I missing? :)

@develar
Copy link
Member

develar commented Sep 1, 2017

And you don't want to change author?

@framerate
Copy link
Author

And you don't want to change author?

Package.json author I believe is following this format: https://docs.npmjs.com/files/package.json

I have:

    "author": {
        "email": "[email protected]",
        "name": "My Company"
    }

I would expect that to use My Company for the company name, copyright and start menu (instead of my personal email address) but maybe that's not the case?

@develar
Copy link
Member

develar commented Sep 1, 2017

We parse author and use only name component. So, it is indicator that parsing is not correctly implemented. Will investigate.

@framerate
Copy link
Author

I have a two package.json structure, author is in /... not sure whats in /app/ off hand, but maybe that's related

@develar
Copy link
Member

develar commented Sep 1, 2017

Must be in the app package.json

@framerate
Copy link
Author

Oh ok! Lastly, that seems a bit odd since ALL of the other electron-builder stuff is in /package.json right?

Why would this one feature use /app/? Or am I mistaken?

@develar
Copy link
Member

develar commented Sep 1, 2017

Why would this one feature use /app/?

Because author belongs to your app, it is metadata.

electron-builder configuration it is just build configuration, not metadata.

Nevermind — now we check author in the dev metadata also :)

@develar develar added the feature label Sep 1, 2017
@develar
Copy link
Member

develar commented Sep 1, 2017

You are not alone — #1881

@develar
Copy link
Member

develar commented Sep 1, 2017

publisherName intended for code signature validation. Not as company name. As your issue is not about what to use, but misplaced author field, I am not going to think — should we use it as company name or not.

@framerate
Copy link
Author

I think it's just a little confusing. We could fix it by updating documentation too, sure, but the idea of 99% of the time updating /package.json except this case where I need to update /app/package.json (in relation to electron builder). I would think there should be some (maybe new) config option in /package.json that is documented and if that doesn't exist, fall back to /app/package.json#author perhaps.

@develar develar closed this as completed in 03df22d Sep 1, 2017
@develar
Copy link
Member

develar commented Sep 1, 2017

Please try 19.27.6

@framerate
Copy link
Author

framerate commented Sep 1, 2017

Please try 19.27.6

Ok! What i the change? Is it just falling back to /package.json#author to find a name?

@develar
Copy link
Member

develar commented Sep 1, 2017

Yes, fallback to dev metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants