Turn off node_modules deps resolving or the warning about missing deps

[wojtkowiak]

Hey,

I am in the proces of updating [email protected] to the newest one in meteor-desktop.
I did mention in the past 🙂 (#982 (comment)) that I am packing my node_modules into asar before building installer. Now electron-builder is complaining about unresolved deps as node_modules is not present at the time it processes the app.
I know that I can set the ELECTRON_BUILDER_ALLOW_UNRESOLVED_DEPENDENCIES but is still gives a warning (#982 (comment))

Would you add an option to disable this mechanism or at least disable this warning in any way?

Of course I can prepare the PR but just let me know how would you prefer this to be realised?

[develar]

Please see Packager.productionDeps getter. I guess here we should check is node_modules dir exist if beforeBuild is already set. And do nothing if no dir and beforeBuild is set.

[wojtkowiak]

Sth like this wojtkowiak@bbacd3e ?

But maybe better to condition this also with and additional env var?

[develar]

Yep (except that I think no need to exists if beforeBuild not set).

maybe better to condition this also with and additional env var?

No, no pleasure for users to guess such env instead of just "build my app".

[wojtkowiak]

Yep (except that I think no need to exists if beforeBuild not set).

Totally agree: wojtkowiak@17d33ea

Should I add a note in the docs about it somewhere? Maybe in the beforeBuild desc?

[develar]

Maybe in the beforeBuild desc?

👍

[UberMouse]

I can't find any mention of this option in the current version. Is there some other way to not get electron-builder to check for missing deps? Our CI log ends up with nearly 600,000 lines because of all the unresolved deps spam in the logs, so looking for a solution to suppress it.