Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of *.h files breaks a node dependency #2852

Closed
dpgraham opened this issue May 1, 2018 · 2 comments
Closed

Removal of *.h files breaks a node dependency #2852

dpgraham opened this issue May 1, 2018 · 2 comments
Labels

Comments

@dpgraham
Copy link
Contributor

dpgraham commented May 1, 2018

  • 20.11.1
  • DMG

Description

  • The function "collectNodeModules" in NodeModuleCopyHelper.ts filters out all *.h files
  • Appium Desktop imports a library called WebDriverAgent which contains *.h files that are required for the library to function
  • Commenting out name.endsWith(".h") || fixes the problem
  • By the looks of the code in "collectNodeModules", it appears that all *.h files are dropped, regardless of configuration
  • Is it possible to add a configuration to make exceptions for this so that the *.h files will be included in the app?

(cc: @jlipps)

@jlipps
Copy link

jlipps commented May 1, 2018

👍 Ours is just one imaginable case where .h files should be included. I think it makes sense to enable that, even if via an option which is turned off by default.

@dpgraham dpgraham changed the title Removal of *.h breaks a node dependency Removal of *.h files breaks a node dependency May 1, 2018
@dpgraham
Copy link
Contributor Author

dpgraham commented May 2, 2018

@develar I'd be willing to put in a pull request for this. Can I add a config option called preserveNodeModules that copies over the contents of node_modules without dropping files.

@develar develar added the bug label May 3, 2018
@develar develar closed this as completed in 3763f31 May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants