Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closes #2892 #2952

Closed
wants to merge 1 commit into from
Closed

fix: closes #2892 #2952

wants to merge 1 commit into from

Conversation

akimasa
Copy link

@akimasa akimasa commented May 25, 2018

No description provided.

@develar
Copy link
Member

develar commented May 25, 2018

It is already ignored.

if (options.stdio == null) {
    const isDebugEnabled = debug.enabled
    // do not ignore stdout/stderr if not debug, because in this case we will read into buffer and print on error
    options.stdio = [extraOptions != null && extraOptions.isPipeInput ? "pipe" : "ignore", isDebugEnabled ? "inherit" : "pipe", isDebugEnabled ? "inherit" : "pipe"]
  }

Or do you observe another behaviour?

@akimasa
Copy link
Author

akimasa commented May 25, 2018

#2892 (comment)
Could you try building https://github.com/akimasa/electron-quick-start on Windows?
I don't know why but native addon build stucks without this patch.

@akimasa
Copy link
Author

akimasa commented May 25, 2018

options.stdio = [extraOptions != null && extraOptions.isPipeInput ? "pipe" : "ignore", isDebugEnabled ? "inherit" : "pipe", isDebugEnabled ? "inherit" : "pipe"]

When I run the build, option.stdio will be [ 'ignore', 'pipe', 'pipe' ].
That means ignore input, create pipes for stdout and stderr.
However, there are nothing reading output from pipes.
This will cause build process stuck.
We need to read pipe or ignore output or maybe another solution.

@develar develar closed this in c31f6a1 May 26, 2018
@akimasa
Copy link
Author

akimasa commented May 26, 2018

I confirmed fix in the latest version.
Thank you!

@akimasa akimasa deleted the stuck branch May 26, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants