Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x64 prebuilt binaries get overridden by ia32 binaries during dependency rebuild #3038

Closed
adlk opened this issue Jun 25, 2018 · 3 comments
Closed

x64 prebuilt binaries get overridden by ia32 binaries during dependency rebuild #3038

adlk opened this issue Jun 25, 2018 · 3 comments
Labels
bug

Comments

@adlk
Copy link

adlk commented Jun 25, 2018 •
edited
Loading

  • Version: 20.8.2 / 20.15.0
  • Target: NSIS (32 & 64 bit)

I'm currently dealing with a weird issue with prebuilt binaries for spellchecker on windows for quite some time now using https://github.com/ssbc/electron-spellchecker-prebuilt

Whenever I'm creating a build on my local machine (macOS 10.13.5, electron-builder 20.8.2 - 20.15.0) I get the unpacked folders and the nsis installer for ia32 and x64 which I can run as expected on windows. So far so good. (Can't upgrade to 20.16.0 due to #3039)

If I try to create the build on the CI system (circle ci, docker with builder:wine-mono as well as macOS) the 64bit binary is always broken and results in %1 is not a valid Win32 application.
I have checked the timestamps of the prebuilt binaries and interestingly they are the same in the installed app even though the 64bit has actually been built 6 minutes later. Leading me to the assumption that the 32 bit binary is used for both.

I investigated this further on the CI system and found out that all the files are correct during the first step:

  • rebuilding native production dependencies platform=win32 arch=x64

[...]

> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
> prebuild-install --verbose || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.5.3
prebuild-install info looking for local prebuild @ prebuilds/spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info looking for cached prebuild @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info found cached prebuild 
prebuild-install info unpacking @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info unpack resolved to /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node
prebuild-install info install Successfully installed prebuilt binary!

The spellchecker.node is the 64bit binary (timestamp 19:56:42 indicates this)

-rw-r--r--  2 distiller  staff  482816 Dec 10 19:56:42 2017 release/win-unpacked/resources/app/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node

However, when it comes to creating the 32bit version

  • rebuilding native production dependencies platform=win32 arch=ia32

[...]

> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
> prebuild-install --verbose || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.5.3
prebuild-install info looking for local prebuild @ prebuilds/spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info looking for cached prebuild @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info found cached prebuild 
prebuild-install info unpacking @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info unpack resolved to /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node
prebuild-install info install Successfully installed prebuilt binary!

The spellchecker.node in win-unpacked gets overridden with the 32bit binary (again look at the timestamp)

-rw-r--r--  2 distiller  staff  400384 Dec 10 19:50:23 2017 release/win-unpacked/resources/app/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node

I tried to manually copy the 64bit spellchecker.node to win-unpacked and the app started working.

Build logs

  • electron-builder version=20.15.0
  • publishing will be skipped reason=current build is a part of pull request solution=
                                 set env PUBLISH_FOR_PULL_REQUEST to true to force code signing
                                 There are serious security concerns with PUBLISH_FOR_PULL_REQUEST=true (see the  CircleCI documentation (https://circleci.com/docs/1.0/fork-pr-builds/) for details)
                                 If you have SSH keys, sensitive env vars or AWS credentials stored in your project settings and untrusted forks can make pull requests against your repo, then this option isn't for you.
  • loaded configuration file=package.json ("build" field)
  • effective config config=
                       directories:
                         output: ./release
                         buildResources: build
                       productName: WordPress.com
                       appId: com.automattic.wordpress
                       asar: false
                       files:
                         - ./build/desktop.js
                         - ./public_desktop
                         - from: ./calypso
                           to: ./calypso
                           filter:
                             - public/**/*
                             - '!public/**/*.css.map'
                             - server/pages/**/*
                             - '!server/pages/test'
                             - '!server/pages/README.md'
                             - server/bundler/assets.json
                             - config/*(secrets|_shared|desktop).json
                       mac:
                         icon: ./resource/image/mac/app-icon.icns
                         category: public.app-category.social-networking
                       dmg:
                         title: WordPress.com Installer
                         icon: ./resource/image/mac/dmg-icon.icns
                         iconSize: 150
                         background: ./resource/image/mac/dmg-background/background.png
                         contents:
                           - x: 486
                             'y': 176
                             type: link
                             path: /Applications
                           - x: 156
                             'y': 179
                             type: file
                       win:
                         target:
                           target: nsis
                           arch:
                             - x64
                             - ia32
                         icon: ./resource/image/win/wordpress.ico
                       nsis:
                         oneClick: false
                       linux:
                         target:
                           - deb
                           - tar.gz
                         icon: ./resource/image/linux/512x512.png
                         executableName: wpcom
                         description: WordPress.com Desktop Client
                         synopsis: WordPress.com Desktop client
                         category: Development
                         desktop:
                           StartupNotify: true
                       deb:
                         fpm:
                           - '--name=wordpress.com'
                         depends:
                           - gconf2
                           - gconf-service
                           - libnotify4
                           - libxtst6
                           - libnss3
                       
  • rebuilding native production dependencies platform=win32 arch=x64
  • spawning        command=npm rebuild [email protected] [email protected] [email protected] @paulcbetts/[email protected] @paulcbetts/[email protected] cwd=/Users/distiller/wp-desktop

> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
> prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=1.7.15 runtime=electron arch=x64 platform=win32)
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cldutil.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cldutil_shared.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det_hint_code.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det_impl.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/debug.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/fixunicodevalue.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_entities.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_language.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_ulscript.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/getonescriptspan.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/lang_script.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/offsetmap.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/scoreonescriptspan.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/tote.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/utf8statetable.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_cjk_uni_prop_80.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_cjk_compatible.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_cjk_delta_bi_32.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_distinct_bi_0.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quad0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_deltaocta0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_deltaoctachrome.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_distinctocta0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_distinctoctachrome.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quadchrome_16.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quadchrome_2.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_score_quad_octa_0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_score_quad_octa_2.o
  LIBTOOL-STATIC Release/cld-c.a
  CXX(target) Release/obj.target/cld/src/constants.o
  CXX(target) Release/obj.target/cld/src/cld.o
  SOLINK_MODULE(target) Release/cld.node

> @paulcbetts/[email protected] postinstall /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
> node bin/postinstall.js


> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
> prebuild-install --verbose || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.5.3
prebuild-install info looking for local prebuild @ prebuilds/spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info looking for cached prebuild @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info found cached prebuild 
prebuild-install info unpacking @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-x64.tar.gz
prebuild-install info unpack resolved to /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node
prebuild-install info install Successfully installed prebuilt binary!

> [email protected] install /Users/distiller/wp-desktop/node_modules/keyboard-layout
> prebuild-install || node-gyp rebuild


> [email protected] install /Users/distiller/wp-desktop/node_modules/macos-alias
> node-gyp rebuild

  CXX(target) Release/obj.target/volume/src/volume.o
  SOLINK_MODULE(target) Release/volume.node

> [email protected] install /Users/distiller/wp-desktop/node_modules/fs-xattr
> node-gyp rebuild

  CXX(target) Release/obj.target/xattr/src/async.o
../src/async.cc:35:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/async.cc:129:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/async.cc:186:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
3 warnings generated.
  CXX(target) Release/obj.target/xattr/src/error.o
  CXX(target) Release/obj.target/xattr/src/sync.o
  CXX(target) Release/obj.target/xattr/src/util.o
  CXX(target) Release/obj.target/xattr/src/xattr.o
  SOLINK_MODULE(target) Release/xattr.node
@paulcbetts/[email protected] /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
@paulcbetts/[email protected] /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
[email protected] /Users/distiller/wp-desktop/node_modules/keyboard-layout
[email protected] /Users/distiller/wp-desktop/node_modules/macos-alias
[email protected] /Users/distiller/wp-desktop/node_modules/fs-xattr
  • exited          command=npm code=0 pid=36942
  • packaging       platform=win32 arch=x64 electron=1.7.15 appOutDir=release/win-unpacked
  • executing       file=unzip args=-oqq -d /Users/distiller/wp-desktop/release/win-unpacked /Users/distiller/Library/Caches/electron/electron-v1.7.15-win32-x64.zip
  • executed        file=unzip
  • asar using is disabled — it is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
  • Detect github as publish provider
  • calling getInfo reason=owner or project is not specified explicitly provider=github owner=undefined project=undefined
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder icon --format ico --root /Users/distiller/wp-desktop/build --root /Users/distiller/wp-desktop --out /Users/distiller/wp-desktop/release/.icon-ico --input ./resource/image/win/wordpress.ico --input icon.ico --input icon.png --input icons --input icon.icns
  • path doesn't exist        path=/Users/distiller/wp-desktop/build/resource/image/win/wordpress.ico
  • path resolved             outputFormat=ico path=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico
  • exited          command=app-builder code=0 pid=38835 out={"icons":[{"file":"/Users/distiller/wp-desktop/resource/image/win/wordpress.ico","size":0}]}
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder download-artifact --url https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.0.0/winCodeSign-2.0.0.7z --name winCodeSign-2.0.0 --sha512 QT51iAVlWZlKeip3FPc8FHG/HKhCdWR/Wg+cevhrKHQ1d/oHl49EqXgeztO//DrdyN1X+GCvglaHifXnWR5VXQ==
  • found existing            path=/Users/distiller/Library/Caches/electron-builder/winCodeSign/winCodeSign-2.0.0
  • exited          command=app-builder code=0 pid=38836 out=/Users/distiller/Library/Caches/electron-builder/winCodeSign/winCodeSign-2.0.0
  • macOS version   version=10.12.6
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder download-artifact --url https://github.com/electron-userland/electron-builder-binaries/releases/download/wine-2.0.1-mac-10.12/wine-2.0.1-mac-10.12.7z --name wine-2.0.1-mac-10.12 --sha512 IvKwDml/Ob0vKfYVxcu92wxUzHu8lTQSjjb8OlCTQ6bdNpVkqw17OM14TPpzGMIgSxfVIrQZhZdCwpkxLyG3mg==
  • found existing            path=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12
  • exited          command=app-builder code=0 pid=38837 out=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12
  • executing       file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine args=/Users/distiller/Library/Caches/electron-builder/winCodeSign/winCodeSign-2.0.0/rcedit-ia32.exe /Users/distiller/wp-desktop/release/win-unpacked/WordPress.com.exe --set-version-string FileDescription WordPress.com --set-version-string ProductName WordPress.com --set-version-string LegalCopyright Copyright © 2018 Automattic Inc. --set-file-version 3.3.0-beta1.19439 --set-product-version 3.3.0.19439 --set-version-string InternalName WordPress.com --set-version-string OriginalFilename  --set-version-string CompanyName Automattic Inc. --set-icon /Users/distiller/wp-desktop/resource/image/win/wordpress.ico env=
                      {
                        "WINEDEBUG": "-all,err+all",
                        "WINEDLLOVERRIDES": "winemenubuilder.exe=d",
                        "WINEPREFIX": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/wine-home",
                        "DYLD_FALLBACK_LIBRARY_PATH": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/lib"
                      }
  • executed        file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine stderr=
                      winedevice.exe(38848,0x401f7000) malloc: *** error for object 0x401bc408: pointer being freed was not allocated
                      *** set a breakpoint in malloc_error_break to debug
                      
wine&sign: 5s 78ms
  • rebuilding native production dependencies platform=win32 arch=ia32
  • spawning        command=npm rebuild [email protected] [email protected] [email protected] @paulcbetts/[email protected] @paulcbetts/[email protected] cwd=/Users/distiller/wp-desktop

> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
> prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=1.7.15 runtime=electron arch=ia32 platform=win32)
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cldutil.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cldutil_shared.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det_hint_code.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/compact_lang_det_impl.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/debug.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/fixunicodevalue.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_entities.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_language.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_ulscript.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/getonescriptspan.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/lang_script.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/offsetmap.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/scoreonescriptspan.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/tote.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/utf8statetable.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_cjk_uni_prop_80.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_cjk_compatible.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_cjk_delta_bi_32.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/generated_distinct_bi_0.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quad0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_deltaocta0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_deltaoctachrome.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_distinctocta0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_distinctoctachrome.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quadchrome_16.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld2_generated_quadchrome_2.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_score_quad_octa_0122.o
  CXX(target) Release/obj.target/cld-c/deps/cld/internal/cld_generated_score_quad_octa_2.o
  LIBTOOL-STATIC Release/cld-c.a
  CXX(target) Release/obj.target/cld/src/constants.o
  CXX(target) Release/obj.target/cld/src/cld.o
  SOLINK_MODULE(target) Release/cld.node

> @paulcbetts/[email protected] postinstall /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
> node bin/postinstall.js


> @paulcbetts/[email protected] install /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
> prebuild-install --verbose || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.5.3
prebuild-install info looking for local prebuild @ prebuilds/spellchecker-v4.0.6-electron-v54-win32-ia32.tar.gz
prebuild-install info looking for cached prebuild @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-ia32.tar.gz
prebuild-install info found cached prebuild 
prebuild-install info unpacking @ /Users/distiller/.npm/_prebuilds/https-jackfan.us.kg-ssbc-paulcbetts-spellchecker-prebuilt-releases-download-v4.0.6-spellchecker-v4.0.6-electron-v54-win32-ia32.tar.gz
prebuild-install info unpack resolved to /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker/build/Release/spellchecker.node
prebuild-install info install Successfully installed prebuilt binary!

> [email protected] install /Users/distiller/wp-desktop/node_modules/keyboard-layout
> prebuild-install || node-gyp rebuild


> [email protected] install /Users/distiller/wp-desktop/node_modules/macos-alias
> node-gyp rebuild

  CXX(target) Release/obj.target/volume/src/volume.o
  SOLINK_MODULE(target) Release/volume.node

> [email protected] install /Users/distiller/wp-desktop/node_modules/fs-xattr
> node-gyp rebuild

  CXX(target) Release/obj.target/xattr/src/async.o
../src/async.cc:35:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/async.cc:129:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/async.cc:186:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(2, argv);
              ^
../../nan/nan.h:1617:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
3 warnings generated.
  CXX(target) Release/obj.target/xattr/src/error.o
  CXX(target) Release/obj.target/xattr/src/sync.o
  CXX(target) Release/obj.target/xattr/src/util.o
  CXX(target) Release/obj.target/xattr/src/xattr.o
  SOLINK_MODULE(target) Release/xattr.node
@paulcbetts/[email protected] /Users/distiller/wp-desktop/node_modules/@paulcbetts/cld
@paulcbetts/[email protected] /Users/distiller/wp-desktop/node_modules/@paulcbetts/spellchecker
[email protected] /Users/distiller/wp-desktop/node_modules/keyboard-layout
[email protected] /Users/distiller/wp-desktop/node_modules/macos-alias
[email protected] /Users/distiller/wp-desktop/node_modules/fs-xattr
  • exited          command=npm code=0 pid=38852
  • packaging       platform=win32 arch=ia32 electron=1.7.15 appOutDir=release/win-ia32-unpacked
  • executing       file=unzip args=-oqq -d /Users/distiller/wp-desktop/release/win-ia32-unpacked /Users/distiller/Library/Caches/electron/electron-v1.7.15-win32-ia32.zip
  • executed        file=unzip
  • asar using is disabled — it is strongly not recommended solution=enable asar and use asarUnpack to unpack files that must be externally available
  • Detect github as publish provider
  • calling getInfo reason=owner or project is not specified explicitly provider=github owner=undefined project=undefined
  • executing       file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine args=/Users/distiller/Library/Caches/electron-builder/winCodeSign/winCodeSign-2.0.0/rcedit-ia32.exe /Users/distiller/wp-desktop/release/win-ia32-unpacked/WordPress.com.exe --set-version-string FileDescription WordPress.com --set-version-string ProductName WordPress.com --set-version-string LegalCopyright Copyright © 2018 Automattic Inc. --set-file-version 3.3.0-beta1.19439 --set-product-version 3.3.0.19439 --set-version-string InternalName WordPress.com --set-version-string OriginalFilename  --set-version-string CompanyName Automattic Inc. --set-icon /Users/distiller/wp-desktop/resource/image/win/wordpress.ico env=
                      {
                        "WINEDEBUG": "-all,err+all",
                        "WINEDLLOVERRIDES": "winemenubuilder.exe=d",
                        "WINEPREFIX": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/wine-home",
                        "DYLD_FALLBACK_LIBRARY_PATH": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/lib"
                      }
  • executed        file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine stderr=
                      winedevice.exe(40751,0x401f7000) malloc: *** error for object 0x401bc408: pointer being freed was not allocated
                      *** set a breakpoint in malloc_error_break to debug
                      
wine&sign: 4s 815ms
  • building        target=nsis file=release/WordPress.com Setup 3.3.0-beta1.exe archs=x64, ia32 oneClick=false
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder download-artifact --url https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-3.0.3.0/nsis-3.0.3.0.7z --name nsis-3.0.3.0 --sha512 3cZfTAEgX/iatMcjmh4c8ZSwhO76Oqpneb4UPzT+uWxsAfZdUgSuls3WXwOtb9oY+wqSvY7+WRvO8944RSTUcg==
  • found existing            path=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-3.0.3.0
  • exited          command=app-builder code=0 pid=40754 out=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-3.0.3.0
  • executing       file=/Users/distiller/wp-desktop/node_modules/7zip-bin/mac/7za args=a -bd -mx=9 -md=1m -mtc=off -ms=off -mtm=off -mta=off /Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-ia32.nsis.7z . -xr!*.avi -xr!*.mov -xr!*.m4v -xr!*.mp4 -xr!*.m4p -xr!*.qt -xr!*.mkv -xr!*.webm -xr!*.vmdk cwd=/Users/distiller/wp-desktop/release/win-ia32-unpacked
  • executing       file=/Users/distiller/wp-desktop/node_modules/7zip-bin/mac/7za args=a -bd -mx=9 -md=1m -mtc=off -ms=off -mtm=off -mta=off /Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-x64.nsis.7z . -xr!*.avi -xr!*.mov -xr!*.m4v -xr!*.mp4 -xr!*.m4p -xr!*.qt -xr!*.mkv -xr!*.webm -xr!*.vmdk cwd=/Users/distiller/wp-desktop/release/win-unpacked
nsis package, ia32: 50s 758ms
nsis package, x64: 55s 183ms
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder download-artifact --url https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-resources-3.3.0/nsis-resources-3.3.0.7z --name nsis-resources-3.3.0 --sha512 4okc98BD0v9xDcSjhPVhAkBMqos+FvD/5/H72fTTIwoHTuWd2WdD7r+1j72hxd+ZXxq1y3FRW0x6Z3jR0VfpMw==
  • found existing            path=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-resources-3.3.0
  • exited          command=app-builder code=0 pid=40761 out=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-resources-3.3.0
  • spawning        command=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-3.0.3.0/mac/makensis -WX -DAPP_ID=com.automattic.wordpress -DAPP_GUID=ed4e3354-70d4-58f5-8f6d-7420253356e2 -DPRODUCT_NAME=WordPress.com -DPRODUCT_FILENAME=WordPress.com -DAPP_FILENAME=WordPress.com -DAPP_DESCRIPTION=Desktop version of WordPress.com -DVERSION=3.3.0-beta1 -DPROJECT_DIR=/Users/distiller/wp-desktop -DBUILD_RESOURCES_DIR=/Users/distiller/wp-desktop/build -DMUI_ICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico -DMUI_UNICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico -DAPP_32=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-ia32.nsis.7z -DAPP_32_NAME=WordPressDesktop-3.3.0-beta1-ia32.nsis.7z -DAPP_32_HASH=F5E5533B415A0991CCCDB1211D2BB287EC10583683368F55D6E7B22999486CD582803C768E88307BB58D709C755662CC66A537221D9093316CBBEFEF64BE9C9E -DAPP_64=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-x64.nsis.7z -DAPP_64_NAME=WordPressDesktop-3.3.0-beta1-x64.nsis.7z -DAPP_64_HASH=663EFB0F1DD8F8DC79C233957B7F9B6964AB66256808FCF2823E8F6E4F3688321FEF4AA107874B281CE87649BAE89C29BC0EEB99E41E4B43279A15B55245F92C -DCOMPANY_NAME=Automattic Inc. -DAPP_INSTALLER_STORE_FILE=WordPress.com\installer.exe -DCOMPRESSION_METHOD=7z -DMULTIUSER_INSTALLMODE_ALLOW_ELEVATION -DINSTALL_MODE_PER_ALL_USERS_REQUIRED -DSHORTCUT_NAME=WordPress.com -DUNINSTALL_DISPLAY_NAME=WordPress.com 3.3.0-beta1 -DMUI_WELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp -DMUI_UNWELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp -DCOMPRESS=auto -DBUILD_UNINSTALLER -DUNINSTALLER_OUT_FILE=Z:\Users\distiller\wp-desktop\release\.__uninstaller-nsis-WordPressDesktop.exe -XOutFile "/Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe" -XVIProductVersion 3.3.0.19439 -XVIAddVersionKey /LANG=1033 ProductName "WordPress.com" -XVIAddVersionKey /LANG=1033 ProductVersion "3.3.0-beta1" -XVIAddVersionKey /LANG=1033 LegalCopyright "Copyright © 2018 Automattic Inc." -XVIAddVersionKey /LANG=1033 FileDescription "Desktop version of WordPress.com" -XVIAddVersionKey /LANG=1033 FileVersion "3.3.0-beta1.19439" -XVIAddVersionKey /LANG=1033 CompanyName "Automattic Inc." -XUnicode true -XSetCompressor zlib - cwd=/Users/distiller/wp-desktop/node_modules/electron-builder-lib/templates/nsis
Command line defined: "APP_ID=com.automattic.wordpress"
Command line defined: "APP_GUID=ed4e3354-70d4-58f5-8f6d-7420253356e2"
Command line defined: "PRODUCT_NAME=WordPress.com"
Command line defined: "PRODUCT_FILENAME=WordPress.com"
Command line defined: "APP_FILENAME=WordPress.com"
Command line defined: "APP_DESCRIPTION=Desktop version of WordPress.com"
Command line defined: "VERSION=3.3.0-beta1"
Command line defined: "PROJECT_DIR=/Users/distiller/wp-desktop"
Command line defined: "BUILD_RESOURCES_DIR=/Users/distiller/wp-desktop/build"
Command line defined: "MUI_ICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico"
Command line defined: "MUI_UNICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico"
Command line defined: "APP_32=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-ia32.nsis.7z"
Command line defined: "APP_32_NAME=WordPressDesktop-3.3.0-beta1-ia32.nsis.7z"
Command line defined: "APP_32_HASH=F5E5533B415A0991CCCDB1211D2BB287EC10583683368F55D6E7B22999486CD582803C768E88307BB58D709C755662CC66A537221D9093316CBBEFEF64BE9C9E"
Command line defined: "APP_64=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-x64.nsis.7z"
Command line defined: "APP_64_NAME=WordPressDesktop-3.3.0-beta1-x64.nsis.7z"
Command line defined: "APP_64_HASH=663EFB0F1DD8F8DC79C233957B7F9B6964AB66256808FCF2823E8F6E4F3688321FEF4AA107874B281CE87649BAE89C29BC0EEB99E41E4B43279A15B55245F92C"
Command line defined: "COMPANY_NAME=Automattic Inc."
Command line defined: "APP_INSTALLER_STORE_FILE=WordPress.com\installer.exe"
Command line defined: "COMPRESSION_METHOD=7z"
Command line defined: "MULTIUSER_INSTALLMODE_ALLOW_ELEVATION"
Command line defined: "INSTALL_MODE_PER_ALL_USERS_REQUIRED"
Command line defined: "SHORTCUT_NAME=WordPress.com"
Command line defined: "UNINSTALL_DISPLAY_NAME=WordPress.com 3.3.0-beta1"
Command line defined: "MUI_WELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp"
Command line defined: "MUI_UNWELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp"
Command line defined: "COMPRESS=auto"
Command line defined: "BUILD_UNINSTALLER"
Command line defined: "UNINSTALLER_OUT_FILE=Z:\Users\distiller\wp-desktop\release\.__uninstaller-nsis-WordPressDesktop.exe"
Processing script file: "<stdin>" (UTF8)

Processed 1 file, 10 command line commands, writing output (x86-unicode):

Output: "/Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe"
Install: 0 pages (0 bytes), 1 section (32792 bytes), 27 instructions (756 bytes), 2335 strings (19410 bytes), 24 language tables (3984 bytes).
Uninstall: 4 pages (320 bytes), 1 section (32792 bytes), 1572 instructions (44016 bytes), 6308 strings (76442 bytes), 24 language tables (7824 bytes).

Using zlib compression.

EXE header size:              215552 / 39424 bytes
Install code:                   8156 / 40934 bytes
Install data:                      0 / 8 bytes
Uninstall code+data:          147199 / 267977 bytes
CRC (0x2B735A3B):                  4 / 4 bytes

Total size:                   370911 / 348347 bytes (106.4%)
  • exited          command=makensis code=0 pid=40762
  • executing       file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine args=/Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe env=
                      {
                        "WINEDEBUG": "-all,err+all",
                        "WINEDLLOVERRIDES": "winemenubuilder.exe=d",
                        "WINEPREFIX": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/wine-home",
                        "DYLD_FALLBACK_LIBRARY_PATH": "/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/lib"
                      }
  • executed        file=/Users/distiller/Library/Caches/electron-builder/wine/wine-2.0.1-mac-10.12/bin/wine stderr=
                      winedevice.exe(40773,0x401f7000) malloc: *** error for object 0x4020bd10: pointer being freed was not allocated
                      *** set a breakpoint in malloc_error_break to debug
                      
  • spawning        command=/Users/distiller/Library/Caches/electron-builder/nsis/nsis-3.0.3.0/mac/makensis -WX -DAPP_ID=com.automattic.wordpress -DAPP_GUID=ed4e3354-70d4-58f5-8f6d-7420253356e2 -DPRODUCT_NAME=WordPress.com -DPRODUCT_FILENAME=WordPress.com -DAPP_FILENAME=WordPress.com -DAPP_DESCRIPTION=Desktop version of WordPress.com -DVERSION=3.3.0-beta1 -DPROJECT_DIR=/Users/distiller/wp-desktop -DBUILD_RESOURCES_DIR=/Users/distiller/wp-desktop/build -DMUI_ICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico -DMUI_UNICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico -DAPP_32=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-ia32.nsis.7z -DAPP_32_NAME=WordPressDesktop-3.3.0-beta1-ia32.nsis.7z -DAPP_32_HASH=F5E5533B415A0991CCCDB1211D2BB287EC10583683368F55D6E7B22999486CD582803C768E88307BB58D709C755662CC66A537221D9093316CBBEFEF64BE9C9E -DAPP_64=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-x64.nsis.7z -DAPP_64_NAME=WordPressDesktop-3.3.0-beta1-x64.nsis.7z -DAPP_64_HASH=663EFB0F1DD8F8DC79C233957B7F9B6964AB66256808FCF2823E8F6E4F3688321FEF4AA107874B281CE87649BAE89C29BC0EEB99E41E4B43279A15B55245F92C -DCOMPANY_NAME=Automattic Inc. -DAPP_INSTALLER_STORE_FILE=WordPress.com\installer.exe -DCOMPRESSION_METHOD=7z -DMULTIUSER_INSTALLMODE_ALLOW_ELEVATION -DINSTALL_MODE_PER_ALL_USERS_REQUIRED -DSHORTCUT_NAME=WordPress.com -DUNINSTALL_DISPLAY_NAME=WordPress.com 3.3.0-beta1 -DMUI_WELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp -DMUI_UNWELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp -DCOMPRESS=auto -DUNINSTALLER_OUT_FILE=/Users/distiller/wp-desktop/release/.__uninstaller-nsis-WordPressDesktop.exe -XOutFile "/Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe" -XVIProductVersion 3.3.0.19439 -XVIAddVersionKey /LANG=1033 ProductName "WordPress.com" -XVIAddVersionKey /LANG=1033 ProductVersion "3.3.0-beta1" -XVIAddVersionKey /LANG=1033 LegalCopyright "Copyright © 2018 Automattic Inc." -XVIAddVersionKey /LANG=1033 FileDescription "Desktop version of WordPress.com" -XVIAddVersionKey /LANG=1033 FileVersion "3.3.0-beta1.19439" -XVIAddVersionKey /LANG=1033 CompanyName "Automattic Inc." -XUnicode true -XSetCompressor zlib - cwd=/Users/distiller/wp-desktop/node_modules/electron-builder-lib/templates/nsis
Command line defined: "APP_ID=com.automattic.wordpress"
Command line defined: "APP_GUID=ed4e3354-70d4-58f5-8f6d-7420253356e2"
Command line defined: "PRODUCT_NAME=WordPress.com"
Command line defined: "PRODUCT_FILENAME=WordPress.com"
Command line defined: "APP_FILENAME=WordPress.com"
Command line defined: "APP_DESCRIPTION=Desktop version of WordPress.com"
Command line defined: "VERSION=3.3.0-beta1"
Command line defined: "PROJECT_DIR=/Users/distiller/wp-desktop"
Command line defined: "BUILD_RESOURCES_DIR=/Users/distiller/wp-desktop/build"
Command line defined: "MUI_ICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico"
Command line defined: "MUI_UNICON=/Users/distiller/wp-desktop/resource/image/win/wordpress.ico"
Command line defined: "APP_32=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-ia32.nsis.7z"
Command line defined: "APP_32_NAME=WordPressDesktop-3.3.0-beta1-ia32.nsis.7z"
Command line defined: "APP_32_HASH=F5E5533B415A0991CCCDB1211D2BB287EC10583683368F55D6E7B22999486CD582803C768E88307BB58D709C755662CC66A537221D9093316CBBEFEF64BE9C9E"
Command line defined: "APP_64=/Users/distiller/wp-desktop/release/WordPressDesktop-3.3.0-beta1-x64.nsis.7z"
Command line defined: "APP_64_NAME=WordPressDesktop-3.3.0-beta1-x64.nsis.7z"
Command line defined: "APP_64_HASH=663EFB0F1DD8F8DC79C233957B7F9B6964AB66256808FCF2823E8F6E4F3688321FEF4AA107874B281CE87649BAE89C29BC0EEB99E41E4B43279A15B55245F92C"
Command line defined: "COMPANY_NAME=Automattic Inc."
Command line defined: "APP_INSTALLER_STORE_FILE=WordPress.com\installer.exe"
Command line defined: "COMPRESSION_METHOD=7z"
Command line defined: "MULTIUSER_INSTALLMODE_ALLOW_ELEVATION"
Command line defined: "INSTALL_MODE_PER_ALL_USERS_REQUIRED"
Command line defined: "SHORTCUT_NAME=WordPress.com"
Command line defined: "UNINSTALL_DISPLAY_NAME=WordPress.com 3.3.0-beta1"
Command line defined: "MUI_WELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp"
Command line defined: "MUI_UNWELCOMEFINISHPAGE_BITMAP=${NSISDIR}\Contrib\Graphics\Wizard\nsis3-metro.bmp"
Command line defined: "COMPRESS=auto"
Command line defined: "UNINSTALLER_OUT_FILE=/Users/distiller/wp-desktop/release/.__uninstaller-nsis-WordPressDesktop.exe"
Processing script file: "<stdin>" (UTF8)

Processed 1 file, 10 command line commands, writing output (x86-unicode):

Output: "/Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe"
Install: 3 pages (192 bytes), 1 section (32792 bytes), 1858 instructions (52024 bytes), 7133 strings (74052 bytes), 24 language tables (7728 bytes).

Using zlib compression.

EXE header size:              215552 / 39424 bytes
Install code:                  31185 / 150844 bytes
Install data:              113758703 / 114314781 bytes
CRC (0x975773A9):                  4 / 4 bytes

Total size:                114005444 / 114505053 bytes (99.5%)
  • exited          command=makensis code=0 pid=40778
  • building block map blockMapFile=release/WordPress.com Setup 3.3.0-beta1.exe.blockmap
  • spawning        command=/Users/distiller/wp-desktop/node_modules/app-builder-bin/mac/app-builder blockmap --input /Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe --output /Users/distiller/wp-desktop/release/WordPress.com Setup 3.3.0-beta1.exe.blockmap
  • exited          command=app-builder code=0 pid=40779 out={"size":114005444,"sha512":"X//xZzBdTWGImmblPNeN00T0HmWSIp0hNvhL2l5IKEQ4mQBnLlOHJey9LBlk+AbljwDzVpp1S1m4iG1NoaS7nQ=="}
  • Detect github as publish provider
  • calling getInfo reason=owner or project is not specified explicitly provider=github owner=undefined project=undefined
  • Detect github as publish provider
  • calling getInfo reason=owner or project is not specified explicitly provider=github owner=undefined project=undefined
✓ App built

@adlk adlk mentioned this issue Jun 26, 2018
Closed
@adlk
Copy link
Author

adlk commented Jun 27, 2018

From a conversation with @develar on slack:
It is necessary to set the env var USE_HARD_LINKS=false otherwise the binary will be overwritten.

CircleCI bonus pitfall:

- run:
    name: Build
    environment:
      USE_HARD_LINKS: "false"
    command: |
            npx electron-builder build

In the CircleCI config USE_HARD_LINKS must be defined as a string otherwise it will be converted to 0 which doesn't work.

@adlk adlk closed this as completed Jun 27, 2018
@develar develar reopened this Jun 27, 2018
@develar
Copy link
Member

develar commented Jun 27, 2018

Ouch, USE_HARD_LINKS also affects this? Need to fix.

@adlk
Copy link
Author

adlk commented Jun 27, 2018 •
edited
Loading

Yep, without USE_HARD_LINKS or USE_HARD_LINKS=0 it did overwrite the binary. Only USE_HARD_LINKS=false did the trick.

@develar develar added the bug label Jun 27, 2018
@evertonfraga evertonfraga mentioned this issue Jul 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develar @adlk