Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 3054: ELECTRON_BUILDER_NSIS_DIR setting #3068

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

shaluyadav13
Copy link
Contributor

@shaluyadav13 shaluyadav13 commented Jul 2, 2018

Info: #3054
space at the end of the path was creating problem while copying a file from src to the destination.

@shaluyadav13 shaluyadav13 changed the title fix Issue #3054: ELECTRON_BUILDER_NSIS_DIR setting fix Issue https://github.com/electron-userland/electron-builder/issues/3054: ELECTRON_BUILDER_NSIS_DIR setting Jul 2, 2018
@shaluyadav13 shaluyadav13 changed the title fix Issue https://github.com/electron-userland/electron-builder/issues/3054: ELECTRON_BUILDER_NSIS_DIR setting fix Issue 3054: ELECTRON_BUILDER_NSIS_DIR setting Jul 2, 2018
@develar develar merged commit 703a1fb into electron-userland:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants