Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does electron-builder work with loginhelper? #3302

Closed
holgersindbaek opened this issue Sep 5, 2018 · 6 comments
Closed

Does electron-builder work with loginhelper? #3302

holgersindbaek opened this issue Sep 5, 2018 · 6 comments

Comments

@holgersindbaek
Copy link

  • Version: 20.28.2
  • Target: mas

I'm trying to implement Electron's new login helper with my Mac app, but I can't seem to get it to work. I'm using electron-builder to build my mac app and it seems there's a specific step in the build process to get the login helper to work:

https://electronjs.org/docs/tutorial/mac-app-store-submission-guide

Can someone confirm that electron-builder does or does not work with electron's new login helper?

@holgersindbaek
Copy link
Author

When I look in the mac console, I get the following error when l double click the login helper: "Process is not in an inherited sandbox."

screen shot 2018-09-07 at 17 44 21

It seems like someone else has had the same problem in their Electron build process:

electron/electron#5248

Is it me doing something wrong or does electron-builder simply not support the login helper functionality?

@holgersindbaek
Copy link
Author

I still haven't figured this out. Am I really the only one who is experiencing this issue?

@holgersindbaek
Copy link
Author

I've started a bounty on SO if anyone feel like looking into it:

https://stackoverflow.com/questions/52709467/electron-login-helper-wont-work-process-is-not-in-an-inherited-sandbox

@holgersindbaek
Copy link
Author

I ended up signing my application again using Electron's guide - https://github.com/electron/electron/blob/master/docs/tutorial/mac-app-store-submission-guide.md - and now the start at login works.

I'm leaving the bug open, since it should be electron-builder's job to do this.

@develar develar added the mac label Oct 26, 2018
@stale
Copy link

stale bot commented Jul 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Jul 2, 2019
@stale stale bot closed this as completed Jul 9, 2019
@jack-arms
Copy link
Contributor

Can this be reopened? It seems electron-builder is still not able to sign the login item helper incorrectly on the latest version?

@holgersindbaek were you able to get around this while still using electron-builder, e.g. with afterPack or something like that? Or did you skip electron-builder entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants