Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-updater size #3953

Closed
astoilkov opened this issue Jun 7, 2019 · 7 comments
Closed

electron-updater size #3953

astoilkov opened this issue Jun 7, 2019 · 7 comments

Comments

@astoilkov
Copy link

astoilkov commented Jun 7, 2019

  • Version: electron-updater 4.0.6
  • Target: macOS

electron-updater increases the bundle size of our main process script by 22 times to half a megabyte. Pasting the screenshots produced by webpack bundle analyzer plugin:

Without electron-updater:
image

With electron-updater:
image

electron-builder is the most popular tool for packaging and publishing apps and I love it. It is so easy to work with. The auto-updating feature is so easy to set up. However, seeing that our app will load slower makes me think about the decision to use the electron-updater plugin.

Is there a way to minimize the bundle size by using different libraries to do the same? I am pasting a few resources to show where the size problems are.

https://bundlephobia.com/[email protected]

https://bundlephobia.com/scan-results?packages=@types/[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]

image

@develar
Copy link
Member

develar commented Jul 1, 2019

Screenshot 2019-07-01 at 10 22 43

result for 4.1.0 — https://bundlephobia.com/[email protected]

2 less dependencies. Can be reduced further.

@stale
Copy link

stale bot commented Aug 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Aug 30, 2019
@astoilkov
Copy link
Author

Please don't close this issue as @develar said: "Can be reduced further.".

@stale stale bot removed the backlog label Aug 30, 2019
@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Oct 29, 2019
@astoilkov
Copy link
Author

Please don't close this issue as @develar said: "Can be reduced further.".

@stale stale bot removed the backlog label Oct 29, 2019
@stale
Copy link

stale bot commented Dec 28, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Dec 28, 2019
@stale stale bot closed this as completed Jan 4, 2020
@sandeep1995
Copy link
Contributor

Please don't close this issue as @develar said: "Can be reduced further.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants