Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder 21 feedback #4018

Closed
develar opened this issue Jul 5, 2019 · 12 comments
Closed

electron-builder 21 feedback #4018

develar opened this issue Jul 5, 2019 · 12 comments

Comments

@develar
Copy link
Member

develar commented Jul 5, 2019

Please try version 21. Please do not file issues about old version (< 21), quite a lot of things were fixed and polished in 21.

21 is ready for production use, but it is not marked as "release" yet, because to simplify your possible migration (or addition) from deb/AppImage to snap, support publishing to Snapcraft is a blocking issue for release.

electron-updater >= 4.11.0 is recommended to use with electron-builder 21.

@ZaneL
Copy link

ZaneL commented Jul 9, 2019

I haven't gotten a chance to try the new version yet on my Pi...hopefully I can in the next day or two. I think it would be really neat to get electron snaps working on Ubuntu Core on a raspberry pi.

To get graphical snaps working on Ubuntu Core, you have to install mir-kiosk https://snapcraft.io/mir-kiosk which acts as the display server. Then you have to integrate a plugin called "xwayland-kiosk-helper" into the electron snap which converts electron's X11 calls into wayland calls. The electron snap would then communicate with mir-kiosk to display the content.

https://tutorials.ubuntu.com/tutorial/electron-kiosk#3

@develar develar changed the title electron-builder 21 beta feedback electron-builder 21 feedback Jul 11, 2019
@develar
Copy link
Member Author

develar commented Jul 11, 2019

@ZaneL Thanks, now I understand how do I can install ubuntu core and for what template for arm64 should be provided.

@ZaneL
Copy link

ZaneL commented Jul 12, 2019

I would just install this image that is ready to go:

https://ubuntu.com/download/iot/raspberry-pi-2-3-core

It is a standard armhf 32 bit image. It's basically just a super stripped down linux kernel with snapd installed, so that you can install snaps and run them.

@sapkra
Copy link
Contributor

sapkra commented Jul 16, 2019

electron-builder 21 was released (21.0.15) but there are no updated docker images.
When are you planning the upload them to Docker Hub?

@audiolion
Copy link

I seem to be having an issue where file macros arent being expanded, when publishing to s3 with the following config:

"publish": {
      "provider": "s3",
      "region": "us-east-1",
      "bucket": "cdn.kimmel.io",
      "channel": "${env.NEXUS_ELECTRON_CHANNEL}",
      "path": "${env.NEXUS_ELECTRON_S3_PATH}",
      "acl": "public-read"
    }

the app was published to:

image

it interpreted the path literally.

I am using an electron-builder.env file in the current directory I am running the cli command from. that doesnt seem to be working because the publish failed until I moved the AWS_ACCESS_KEY_ID and AWS_ACCESS_SECRET_KEY to ~/.aws/credentials.

I tried exporting from the command line before running, same result, uploaded to the literal path and didnt expand the macro. I also tried exporting within the command itself e.g.

export NEXUS_ELECTRON_S3_PATH=/desktop && yarn build:desktop

and still the same result.

@Topppy
Copy link

Topppy commented Aug 28, 2019

the latest electron-updater version I can get on npm is 4.1.2. How can I get electron-updater >= 4.11.0?

@danwid
Copy link

danwid commented Sep 9, 2019

I'm having similar issues with one of the referred issues
#3684

Cannot download differentially, fallback to full download: Error: Maximum allowed size is 5 MB

windows 8.1 pro
private github repo
electron-builder 21.2.0
electron 6.0.7
electron-updater 4.1.2

@wesionaire
Copy link

wesionaire commented Sep 9, 2019

I'm having similar issues with one of the referred issues
#3684

Cannot download differentially, fallback to full download: Error: Maximum allowed size is 5 MB

We have the same problem (private Github repo)

  • Target Windows 10 x64
  • name & productName are the same
[2019-09-09 13:00:53.016] [info] No cached update info available
[2019-09-09 13:00:53.029] [info] Download block maps (old: "https://api.github.com/repos/wesionaire/xxx/releases/assets/14823427.blockmap", new: https://api.github.com/repos/wesionaire/xxx/releases/assets/14823427.blockmap)
[2019-09-09 13:00:53.463] [error] Cannot download differentially, fallback to full download: Error: Maximum allowed size is 5 MB

@mcous
Copy link

mcous commented Sep 11, 2019

Hey @develar, thanks for all your hard work on this project! I'm in the process of updating our Electron app from electron-builder v20 to v21, and I wanted to share my feedback in case it's helpful

  • electron-builder: 21.2.0
  • electron-updater: 4.1.2
  • electron: 6.0.7
  • targets: macOS (DMG, ZIP), Windows (NSIS), Linux (AppImage)

TL;DR: I feel like I need to upgrade to v21 for my macOS users and the imminent Catalina release with notarization requirements, but:

  • I'm unable to upgrade to the latest v21 on Windows because of a registry bug
  • My (new) Linux users are going to lose desktop integration because AppImageLauncher is not compatible with electron-updater and doesn't seem to be a fully working product.

macOS

The upgrade for macOS has gone mostly smoothly. Notarization for macOS 10.15 Catalina with the DMG target works really well!

There's a minor issue with The ZIP target and macOS Catalina's built-in Archive Utility - See #4179 (comment) for a detailed breakdown. It doesn't appear to affect update functionality, so shipping the DMG only to users works fine.

Windows

We've had to lock electron-builder to 21.1.2 on Windows due to a breaking change to Windows uninstall registry entries introduced by #4069 and landed in 21.1.3.

Due to the change in the registry key format of the uninstall registry entry and the failure of the installer to remove for old-format keys, the user is left with duplicate entries in their "Add and Remove Programs" utility after upgrading their app. See #4092 for more details.

Linux

IMO the removal of built-in Desktop integration in favor of AppImageLauncher was premature. In my testing, AppImageLauncher is both not ready for prime time nor does it interact well with electron-update. I have encountered the following issues:

  • Intermittent missing files in AppImages copied to the Applications directory by AppImageLauncher
    • In the worst case, I ended up with AppImages that were missing app-update.yml!
    • I haven't created a minimal repro for this, but I can if you're interested
  • AppImageLauncher is completely incompatible with electron-updater's AppImage update mechanism
    • electron-updater relies on process.env.APPIMAGE to be the location of the source AppImage to replace
    • AppImageLauncher launches the AppImages from an AppImageLauncher-specific directory, resulting the process.env.APPIMAGE to be set to something like /run/user/1000/appimagelauncherfs/0001.AppImage
    • electron-updater happens to error out when it attempts to unlinkSync that file, but even if it were able to remove it, it would try to move the upgrade file to the completely wrong place rather than ~/Applications, where AppImageLauncher keeps the source AppImages
    • See Electron-updater: Appimage linux updater fails with ENOSYS: function not implemented #4046 for more details

@TanninOne
Copy link

#3185 is still not fixed (as of 21.2.0) so stuck with 20.15.0

@AleksMeshkov
Copy link

4092 is also doesn't seem to be fixed.

@TheAssassin
Copy link

Regarding AppImageLauncher, please see #4046 (comment).

@mmaietta mmaietta closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests