NSIS uninstaller reader (#4305) #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutzroeder
changed the title
|
You are hero. Does it mean that we can build NSIS uninstaller on any OS as before on macOS Catalina? |
|
It's a pretty targeted workaround that seems to work for simple NSIS files with a single nested section containing the uninstaller. One idea would be to run both code paths on all builds for a while and throw an error if the resulting files aren't 100% equal. If users are fine switch over. The code throws aggressively on anything unknown and falls back to the existing code paths (only tested on Catalina). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.