Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Create Pre-Releases and Releases #446

Closed
vlad-shatskyi opened this issue May 29, 2016 · 8 comments · May be fixed by qcif/data-curator#563
Closed

Add Ability to Create Pre-Releases and Releases #446

vlad-shatskyi opened this issue May 29, 2016 · 8 comments · May be fixed by qcif/data-curator#563

Comments

@vlad-shatskyi
Copy link

As far as I understand, currently electron-builder only allows to create drafts. it would be cool to be able to publish those in order to automate the release process.

@develar
Copy link
Member

develar commented May 30, 2016

How do you trigger release in this case? Tag? I don't like it — #340 (comment)

@vlad-shatskyi
Copy link
Author

build --draft=false --prerelease=true or similar, if you want to match Github API. The thing is, currently publishing via electron-builder requires human interaction: I'd need to open the Github releases page, click "Edit" on the latest draft, and then publish it. It means that there is no way to completely automate the release process, unless I'm missing something.

@develar
Copy link
Member

develar commented May 31, 2016

requires human interaction

In your case you need to execute build --draft=false --prerelease=true on your development machine, right? i.e. human interaction in any case is required. And it is not good to publish from development machine, it is better to use CI server (Travis).

I am not against, just want to understand your workflow.

@vlad-shatskyi
Copy link
Author

Not really, the intended setup is to execute this command on Travis every time something is merged into a particular branch. Actually, I already have a workaround using a bash script, if you're interested. https://github.com/shockone/black-screen/blob/master/housekeeping/deploy.sh

@limoragni
Copy link

I think this would be a very nice addition. In my workflow I would like to mark as pre-release those releases that come from the development branch. As it is now I would have to manually mark each dev release as a pre-release. With this option I would just need to know (on the CI server) which is the branch I'm building and use the flag when it has to be used.

@develar
Copy link
Member

develar commented Jun 11, 2016

Proposal:

Env EP_DRAFT bool, EP_PRELEASE bool.
CLI draft, prerelease.

Once GitHub will unblock our test account, will be pushed and released.

@develar
Copy link
Member

develar commented Jun 22, 2016

@ShockOne Are new options suitable for you?

@vlad-shatskyi
Copy link
Author

I haven't tried yet, but they must be, thank you for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants