Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-gyp for darwin targets if build on Linux or in Docker #5193

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

IKukhta
Copy link
Contributor

@IKukhta IKukhta commented Aug 1, 2020

Same issue as #3049 but for 'darwin' target.

node-libcurl fails to download precompiled binaries for darwin target:

2020-08-01 05:53:38 | node-pre-gyp verb cli [
2020-08-01 05:53:38 | node-pre-gyp verb cli '/usr/local/bin/node',
2020-08-01 05:53:38 | node-pre-gyp verb cli '/project/node_modules/node-libcurl/node_modules/.bin/node-pre-gyp',
2020-08-01 05:53:38 | node-pre-gyp verb cli 'install',
2020-08-01 05:53:38 | node-pre-gyp verb cli '--fallback-to-build'
2020-08-01 05:53:38 | node-pre-gyp verb cli ]
2020-08-01 05:53:38 | node-pre-gyp info using [email protected]
2020-08-01 05:53:38 | node-pre-gyp info using [email protected] | linux | x64
2020-08-01 05:53:38 | node-pre-gyp verb command install []
2020-08-01 05:53:38 | node-pre-gyp WARN Using request for node-pre-gyp https download
2020-08-01 05:53:38 | node-pre-gyp http GET https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-darwin-x64-glibc.tar.gz
2020-08-01 05:53:38 | node-pre-gyp http 404 https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-darwin-x64-glibc.tar.gz
2020-08-01 05:53:38 | node-pre-gyp WARN Tried to download(404): https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-darwin-x64-glibc.tar.gz
2020-08-01 05:53:38 | node-pre-gyp WARN Pre-built binaries not found for [email protected] and [email protected] (electron-v8.1 ABI, glibc) (falling back to source compile with node-gyp)
2020-08-01 05:53:38 | node-pre-gyp http 404 status code downloading tarball https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-darwin-x64-glibc.tar.gz

For windows it is ok:

2020-08-01 05:51:26 | node-pre-gyp info it worked if it ends with ok
2020-08-01 05:51:26 | node-pre-gyp verb cli [
2020-08-01 05:51:26 | node-pre-gyp verb cli '/usr/local/bin/node',
2020-08-01 05:51:26 | node-pre-gyp verb cli '/project/node_modules/node-libcurl/node_modules/.bin/node-pre-gyp',
2020-08-01 05:51:26 | node-pre-gyp verb cli 'install',
2020-08-01 05:51:26 | node-pre-gyp verb cli '--fallback-to-build'
2020-08-01 05:51:26 | node-pre-gyp verb cli ]
2020-08-01 05:51:26 | node-pre-gyp info using [email protected]
2020-08-01 05:51:26 | node-pre-gyp info using [email protected] | linux | x64
2020-08-01 05:51:26 | node-pre-gyp verb command install []
2020-08-01 05:51:26 | node-pre-gyp WARN Using request for node-pre-gyp https download
2020-08-01 05:51:26 | node-pre-gyp http GET https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-win32-x64-unknown.tar.gz
2020-08-01 05:51:26 | node-pre-gyp http 200 https://github.com/JCMais/node-libcurl/releases/download/v2.2.0/node_libcurl-v2.2.0-electron-v8.1-win32-x64-unknown.tar.gz

@develar develar merged commit f44206d into electron-userland:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants