-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for supplying a value for the ‘ignore’ electron-osx-sign property. #5262
Conversation
@develar - Can you merge this PR? If you feel like more work needs to be done on it, I can help. Otherwise, this is blocking us - we need to be able to exclude files/directories from the signing process. Thanks! |
Thanks for PR, I renamed option from |
@bedney Hello, I have some dll files in my project that were signed failed on MacOS when I run
I'd be really appreciateful if you can reply. |
Apparently |
This PR allows users of
electron-builder
to supply additional files to theelectron-osx-sign
utility to ignore during the signing process.NOTE: This PR follows the
electron-osx-sign
utility's signature for this property. That is, it is either a single RegExp as a JSON String or an Array of JSON Strings of RegExps. It is NOT a 'glob' pattern, like many of the other config properties inelectron-builder
. That was more sophistication than I needed.In any case, you use this patch in your config like this:
Note the escaping of the backslash there, as you might expect.
In this case, we are filtering for files/directories ending with
.app
(I had one of those and theelectron-osx-sign
wants to think that they're embedded Mac OS X applications, but this wasn't).Here's the Array version:
Note that this closes #3790.