fix:(nsis): Do not abort when uninstaller fails #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not abort installation when the uninstaller is missing, fails to run or returns error code.
o2genum
changed the title
|
@ustun Installer getting stuck is the same issue occuring in OneClick mode. In OneClick mode, it gets aborted just the same, even though there is no "Aborted" message. |
|
Thank you for the reply @o2genum ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4057, the most commented open issue.
Current behavior: when installer detects previously installed version, it tries to run its uninstaller. And if the uninstaller is missing/entire installation directory is missing/uninstaller is damaged/uninstaller fails with error code - then the installation is aborted and the user has only one option: "Cancel" button.
Proposed behavior: ignore and proceed to installation. The most popular scenario causing the bug #4057 is user manually deleting the installation directory. After that, the user is unable to install the app again. The only way for the user to fix the issue is to manually delete the uninstall registry entry. The sole purpose of the installer is to install the app, so I think it should proceed to installation. Error logging/displaying the error in the installer window might be added latter, but the logic should never prevent the user from installing the app.