Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use v24.0.0-alpha.1 electron-rebuild monorepo behavior #7252

Closed
witcher112 opened this issue Nov 11, 2022 · 2 comments
Closed

Allow to use v24.0.0-alpha.1 electron-rebuild monorepo behavior #7252

witcher112 opened this issue Nov 11, 2022 · 2 comments

Comments

@witcher112
Copy link

  • Electron-Builder Version: 24.0.0-alpha.2
  • Node Version: v16.16.0
  • Electron Version: 17.4.11
  • Electron Type (current, beta, nightly): current
  • Target: Windows, Linux, macOS

While #7212 fixes the monorepo setup of https://github.com/gzdunek/electron-quick-start-monorepo it actually breaks the setup for my project which uses the nohoist workaround (due to the nature of my project's structure, it's actually not a workaround but an intended setup).

Can we perhaps introduce an option to keep the v24.0.0-alpha.1 behavior?

I'm willing to create a PR with such modification, but I would need guidance on where to put the configuration option and how to name it.

@mmaietta
Copy link
Collaborator

Hmmm, which part is breaking by chance? Is the package.json just not able to be found? Is this a two package.json structure?
Happy to review a PR

@witcher112
Copy link
Author

Things have changed and I got rid of the requirement of rebuilding native packages in my project, thus eliminating the problem.

Anyway, thanks for the reply, good job with the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants