Extra field 'adapter' not permitted when using core22 as base for Snapcraft configs

[filfreire]

• Electron-Builder Version: 24.0.0-alpha.10

• Node Version: 16.17

• Electron Version: 22.0.0
• Electron Type (current, beta, nightly): current

• Target: Snapcraft (snap)

If users define core22 as base and define some stage packages, like:

stagePackages: ['default', 'libdbus-1-dev', 'libnss3-dev']

when packaging their apps they might get an error like:

Bad snapcraft.yaml content:
- extra field 'adapter' not permitted in 'apps.insomnia' configuration
Full execution log: '/home/parallels/.cache/snapcraft/log/snapcraft-20230113-002320.808750.log'
  ⨯ exit status 1
github.com/develar/app-builder/pkg/util.ExecuteAndPipeStdOutAndStdErr
        /Volumes/data/Documents/app-builder/pkg/util/exec.go:23
github.com/develar/app-builder/pkg/package-format/snap.buildWithoutTemplate
        /Volumes/data/Documents/app-builder/pkg/package-format/snap/snap.go:352
github.com/develar/app-builder/pkg/package-format/snap.Snap
(...)

this is due to adapter being legacy. See this doc for more info in the Snapcraft provided environment section.

It ends up being this way due to isUseTemplateAppending up as false when folks define stagePackages, hitting this codepath in snap.ts:

this.isUseTemplateApp =
      this.options.useTemplateApp !== false &&
      (arch === Arch.x64 || arch === Arch.armv7l) &&
      buildPackages.length === 0 &&
      isArrayEqualRegardlessOfSort(stagePackages, defaultStagePackages)

one possible workaround might be adding a check for core22

if (snap.base === "core22") {
  delete appDescriptor.adapter
}