From 8f81933b1aec66249e62798fc0515f19c40749d6 Mon Sep 17 00:00:00 2001 From: Michael Maietta Date: Mon, 23 Jan 2023 08:34:07 -0800 Subject: [PATCH 1/3] fix: Manually reseting `GYP_MSVS_VERSION` for multi-arch builds due to electron-rebuild and node-gyp overwriting the default var --- .github/issue_template.md | 1 - docs/configuration/configuration.md | 2 +- packages/app-builder-lib/scheme.json | 2 +- packages/app-builder-lib/src/platformPackager.ts | 3 +++ scripts/jsdoc2md2html.js | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/issue_template.md b/.github/issue_template.md index 14043a7fa6e..c75cf6e5e34 100644 --- a/.github/issue_template.md +++ b/.github/issue_template.md @@ -19,4 +19,3 @@ issue_labeler_regex_version=0 * **Target**: - diff --git a/docs/configuration/configuration.md b/docs/configuration/configuration.md index 00a4c21c1c2..3360d6b0a31 100644 --- a/docs/configuration/configuration.md +++ b/docs/configuration/configuration.md @@ -66,7 +66,7 @@ Env file `electron-builder.env` in the current dir ([example](https://github.com
  • diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json index ca223ced41f..fd47f9365e4 100644 --- a/packages/app-builder-lib/scheme.json +++ b/packages/app-builder-lib/scheme.json @@ -4876,8 +4876,15 @@ ] }, "vendor": { - "description": "Vendor-specific informaton", - "type": "object" + "anyOf": [ + { + "typeof": "function" + }, + { + "type": "null" + } + ], + "description": "Vendor specific information." } }, "type": "object" @@ -7078,4 +7085,4 @@ } }, "type": "object" -} +} \ No newline at end of file diff --git a/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts b/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts index cbe2a158411..d5969b7b0ae 100644 --- a/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts +++ b/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts @@ -147,7 +147,7 @@ export interface ReleaseInfo { /** * Vendor specific information. */ - vendor?: Record | null + vendor?: { [key: string]: any } | null } /** From 464b2d649b199ad1cb9a0417c7ef57bafcd5126a Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Mon, 23 Jan 2023 09:12:50 -0800 Subject: [PATCH 3/3] Create purple-phones-sin.md --- .changeset/purple-phones-sin.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/purple-phones-sin.md diff --git a/.changeset/purple-phones-sin.md b/.changeset/purple-phones-sin.md new file mode 100644 index 00000000000..dfdbf576b8e --- /dev/null +++ b/.changeset/purple-phones-sin.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix: reset `GYP_MSVS_VERSION` for multi-arch builds before `beforePack`