From d9450aa8f473e61105b1fa04546526ec8118d5c6 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Mon, 14 Sep 2020 21:43:34 -0700 Subject: [PATCH] fix(publisher-github): don't reexport Octokit type Re-exporting TypeScript types results in broken JavaScript (the type doesn't exist in JS, resulting in a require error that's hidden by `@electron-forge/core`'s `require-search`). --- packages/publisher/github/src/Config.ts | 2 +- packages/publisher/github/src/util/github.ts | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/publisher/github/src/Config.ts b/packages/publisher/github/src/Config.ts index 09d9298e59..e4bce12114 100644 --- a/packages/publisher/github/src/Config.ts +++ b/packages/publisher/github/src/Config.ts @@ -1,4 +1,4 @@ -import { OctokitOptions } from './util/github'; +import { OctokitOptions } from '@octokit/core/dist-types/types.d'; export interface GitHubRepository { /** diff --git a/packages/publisher/github/src/util/github.ts b/packages/publisher/github/src/util/github.ts index 4f3c8dbf02..ed586ce9f6 100644 --- a/packages/publisher/github/src/util/github.ts +++ b/packages/publisher/github/src/util/github.ts @@ -2,8 +2,6 @@ import { Octokit } from '@octokit/rest'; import { OctokitOptions } from '@octokit/core/dist-types/types.d'; import { merge } from 'lodash'; -export { OctokitOptions } from '@octokit/core/dist-types/types.d'; - export default class GitHub { private options: OctokitOptions;