Jump to unread: implement new design #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Jun 24, 2021
|
|
||
| <attr name="jumpToUnreadStyle" format="reference" /> | ||
|
|
||
| <style name="Widget.Vector.JumpToUnread.Base" parent="Widget.MaterialComponents.Chip.Action"> |
There was a problem hiding this comment.
I would have called this style: Base.Widget.Vector.Chip.Action.JumpToUnread, but anyway it's OK like that :)
| @@ -86,6 +86,7 @@ | |||
| <item name="snackbarButtonStyle">@style/Widget.Vector.SnackBar.Button</item> | |||
| <item name="snackbarTextViewStyle">@style/Widget.Vector.SnackBar.TextView</item> | |||
| <item name="actionModeStyle">@style/Widget.Vector.ActionMode</item> | |||
| <item name="jumpToUnreadStyle">@style/Widget.Vector.JumpToUnread.Dark</item> | |||
There was a problem hiding this comment.
This section is for the default style of the system Widget.
Maybe move this new style at the end of the theme declaration (after vctr_social_login_button_gitlab_style)
| @@ -86,6 +86,7 @@ | |||
| <item name="snackbarButtonStyle">@style/Widget.Vector.SnackBar.Button</item> | |||
| <item name="snackbarTextViewStyle">@style/Widget.Vector.SnackBar.TextView</item> | |||
| <item name="actionModeStyle">@style/Widget.Vector.ActionMode</item> | |||
| <item name="jumpToUnreadStyle">@style/Widget.Vector.JumpToUnread.Light</item> | |||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
|
|
||
| <attr name="jumpToUnreadStyle" format="reference" /> |
There was a problem hiding this comment.
Can you rename to vctr_jump_to_unread_style to follow the current naming convention of custom attributes of this project?
| android:layout_width="0dp" | ||
| <com.google.android.material.chip.Chip | ||
| android:id="@+id/jumpToReadMarkerView" | ||
| style="?attr/jumpToUnreadStyle" |
| android:paddingBottom="12dp" | ||
| android:text="@string/room_jump_to_first_unread" | ||
| android:textColor="?colorOnPrimary" | ||
| app:drawableStartCompat="@drawable/arrow_up_circle" /> |
There was a problem hiding this comment.
This resource (5 png files!) can be removed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new design for Jump to unread.
Also quick fix some issues with his visibility not being refreshed correctly (its more a temporary solution waiting for reworking all that...)