Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new commands #4158

Merged
merged 11 commits into from
Oct 5, 2021
Merged

Handle new commands #4158

merged 11 commits into from
Oct 5, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 4, 2021

Follow up for #2241

Ready to be reviewed!

@bmarty bmarty marked this pull request as ready for review October 4, 2021 14:32
@bmarty bmarty added this to the Sprint - Element 1.3.2 milestone Oct 4, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Unit Test Results

  42 files  ±0    42 suites  ±0   55s ⏱️ ±0s
  83 tests ±0    83 ✔️ ±0  0 💤 ±0  0 ±0 
220 runs  ±0  220 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7ebdd78. ± Comparison against base commit 7ebdd78.

♻️ This comment has been updated with latest results.

@@ -130,7 +131,7 @@ internal class DefaultSendService @AssistedInject constructor(
val messageContent = clearContent?.toModel<MessageContent>() as? MessageWithAttachmentContent ?: return NoOpCancellable

val url = messageContent.getFileUrl() ?: return NoOpCancellable
if (url.startsWith("mxc://")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for extracting this!

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great for me! 👍

device-2021-10-05-102754

@bmarty bmarty merged commit 7ebdd78 into develop Oct 5, 2021
@bmarty bmarty deleted the feature/bma/new_commands branch October 5, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants