Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person should not be set on sent message notifications #4221

Closed
abaker opened this issue Oct 11, 2021 · 1 comment · Fixed by #4222
Closed

Person should not be set on sent message notifications #4221

abaker opened this issue Oct 11, 2021 · 1 comment · Fixed by #4222
Labels
A-Android Auto T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@abaker
Copy link
Contributor

abaker commented Oct 11, 2021

Steps to reproduce

sender should be null when calling MessagingStyle.addMessage for outgoing messages (docs)

This is causing the behavior described in #4205

Intended result and actual result

Android thinks sent messages are actually incoming messages

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Have you submitted a rageshake?

No
@abaker abaker added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 11, 2021
@abaker abaker mentioned this issue Oct 11, 2021
Merged
9 tasks
@ouchadam ouchadam linked a pull request Oct 14, 2021 that will close this issue
Dont set person on sent message notification #4222
Merged
9 tasks
@bmarty
Copy link
Member

bmarty commented Oct 14, 2021

In EA 1.3.4

@bmarty bmarty mentioned this issue Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Android Auto T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont set person on sent message notification
2 participants
@abaker @bmarty