Safer dependencies #4670
Safer dependencies #4670
Conversation
It has been moved to mavenCentral
build.gradle
Outdated
| } | ||
| mavenCentral { | ||
| content { | ||
| includeGroup 'com.adevinta.android' |
There was a problem hiding this comment.
if only we had a way to externalize those lists into another file...
includeGroup does not support taking a list as param
There was a problem hiding this comment.
let me check if that is possible
|
@ariskotsomitopoulos thanks for your proposal solution. I have updated it a bit. Please let me know what you think. |
Yes +1, nice changes! I agree |
| configurations { | ||
| // videocache includes a sl4j logger which causes mockk to attempt to call the static android Log | ||
| testImplementation.exclude group: 'org.slf4j', module: 'slf4j-android' | ||
| } |
There was a problem hiding this comment.
As I removed videocache, I thought I could remove this as well. But maybe double check with @ouchadam first. And I just see that it's still needed: https://github.com/vector-im/element-android/pull/4670/files#diff-f6dc61a00090b6fc204667d7934e656dbb78c8bb0dc14f95468dd57b4300a8caR177
There was a problem hiding this comment.
if videocache is removed then removing this is also fine 👍 (the unit tests will fail if not)
| } | ||
| } | ||
| maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } |
There was a problem hiding this comment.
I am not sure why it has been added at first place, but it seems not necessary anymore 🤞
Ref: