Disabling automatic carousel transitions on user interaction #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extracts all the logic to its own extension
ouchadam
added
the
Z-FTUE
ouchadam
commented
Jan 11, 2022
| override fun onPageSelected(position: Int) { | ||
| scheduledTransition?.cancel() | ||
| override fun onPageScrolled(position: Int, positionOffset: Float, positionOffsetPixels: Int) { | ||
| hasUserManuallyInteractedWithCarousel = !isFakeDragging |
There was a problem hiding this comment.
we check if the scroll was performed by a fake drag, if so we infer that it was the automatic transition and allow the next transition to be scheduled
bmarty
approved these changes
Jan 11, 2022
| override fun onPageSelected(position: Int) { | ||
| scheduledTransition?.cancel() | ||
| if (hasUserManuallyInteractedWithCarousel) { | ||
| // stop the automatic transitions |
There was a problem hiding this comment.
This is fine but maybe avoid having empty block. I think lint/compiler will also complain. Better to write if(!...) and just add the comment above.
There was a problem hiding this comment.
in this case the comment counts as a non empty block, will invert the condition and remove the branch
bmarty
approved these changes
Jan 12, 2022
Matrix SDKIntegration Tests Results:
|
ouchadam
deleted the
feature/adm/ftue-carousel-disable-automatic-transitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4584