Fix sorting of uploads in encrypted rooms #5757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Fixes #2530
There are different loading mechanisms for encrypted and non-encrpyted rooms. The correct sorting was only applied to the non-encrypted codepath, this PR adds sorting to the encrypted codepath too.
Note: this PR won't fix the problem with lazy loading more pages of uploads in the encrypted codepath. I'm new to this codebase and don't see the full implications of that issue, but I'm happy to investigate that further in a separate PR.
Screenshots / GIFs
No screenshots for privacy reasons.
Tests
Open encrypted room with known media history.
Test 1: Open uploads list immediately, without scrolling back up in the timeline to load more media
Test 2: Scroll back in the timeline to cache media, then open uploads list
Tested devices
Checklist