Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doing password stretching on main thread #5871

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Apr 29, 2022

Type of change

  • Bugfix

Content

DefaultSharedSecretStorageService was doing heavy computation on main thread.

Motivation and context

UX will freeze when creating secure backup (or reset)

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_freeze_setup_recovery branch from b152c76 to a1e980d Compare April 29, 2022 08:41
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty enabled auto-merge April 29, 2022 09:07
@github-actions
Copy link

Unit Test Results

118 files  ±0  118 suites  ±0   1m 37s ⏱️ -4s
203 tests ±0  203 ✔️ ±0  0 💤 ±0  0 ±0 
682 runs  ±0  682 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a1e980d. ± Comparison against base commit cd52df5.

@bmarty bmarty merged commit 271eb31 into develop Apr 29, 2022
@bmarty bmarty deleted the feature/bca/fix_freeze_setup_recovery branch April 29, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants