Ensure calling 'fail()' is not caught by the Exception handler

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other : test which should fail may not fail

Content

Ensure tests which should fail are actually failing.

Motivation and context

Make test fail if they have to.

A quick local local test confirm that the test was not failing when fail() is called in a try block and Throwable are caught.

Screenshots / GIFs

NA

Tests

• Run android tests

There are 2 failing tests, not related to this PR: testUnwedging() and trustKeyBackupVersionWithRecoveryKeyTest()

Tested devices

• Physical
• Emulator
• OS version(s):

[github-actions]

Unit Test Results

122 files  ±0  122 suites  ±0   2m 14s ⏱️ -1s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 99d4bbe. ± Comparison against base commit f730378.

♻️ This comment has been updated with latest results.

[BillCarsonFr]

LGTM

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  = passed=20 failures=0 errors=0 skipped=3
• [org.matrix.android.sdk.account]
  = passed=3 failures=0 errors=0 skipped=2
• [org.matrix.android.sdk.internal]
  = passed=51 failures=2 errors=0 skipped=1
• [org.matrix.android.sdk.ordering]
  = passed=16 failures=0 errors=0 skipped=0
• [org.matrix.android.sdk.PermalinkParserTest]
  = passed=2 failures=0 errors=0 skipped=0