Use stable endpoint for alias management

[deepbluev7]

This increases compatibility with homeservers and allows them to remove
Element Android specific workaround.

fixes #4830
see ruma/ruma#936
see matrix-org/synapse#8334
see matrix-org/synapse#9224

Signed-off-by: Nicolas Werner [email protected]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

It makes Element Android (as the last client still relying on the MSC endpoint) use the stable endpoint to list aliases. Fixes #4830

THIS HAS NOT BEEN TESTED SINCE I DON'T HAVE ANY ELEMENT COMPATIBLE DEVICE AND I AM TOO LAZY TO SET UP A DEVELOPMENT ENVIRONMENT FOR THIS.

Motivation and context

Servers shouldn't have to implement MSCs, that have long been merged, to allow Element Android to run on them. This allows the removal of workarounds (or the unstable endpoints) in several server implementations and makes development of new servers easier.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[bmarty]

Thanks for the PR!
We will check that it's working well.
This line has to be modified as well: https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/network/ApiPath.kt#L165. May I ask you to do it please?

Thanks!

[deepbluev7]

Done, thank you for spotting that :3

[deepbluev7]

There is also some reference to the MSC here: https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/alias/GetRoomLocalAliasesTask.kt#L37

I'm not sure if that should be removed or it is a good idea to keep it, since the app might not check for r0.6.1 either?

[bmarty]

There is also some reference to the MSC here: https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/alias/GetRoomLocalAliasesTask.kt#L37

I'm not sure if that should be removed or it is a good idea to keep it, since the app might not check for r0.6.1 either?

Good point. I would vote to simply remove this comment.

[ouchadam]

should the feature be guarded by a homeserver version check?

[deepbluev7]

@ouchadam The old one wasn't guarded by a homeserver version check either and this has been in synapse versions for about a year, I think. A homeserver version check in general would be good, but I think on that old servers a lot of other stuff is broken by now as well and I don't really know, where I would start adding such a check .-.

[ouchadam]

agreed, it's not a blocker for this PR! thinking out loud, I wonder if we should have minimum supported homeserver version (if we don't already)

[deepbluev7]

Does this need anything from me?