Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline] Memory leak in audio message playback tracker #6678

Closed
mnaturel opened this issue Jul 28, 2022 · 0 comments · Fixed by #6679
Closed

[Timeline] Memory leak in audio message playback tracker #6678

mnaturel opened this issue Jul 28, 2022 · 0 comments · Fixed by #6679
Assignees
@mnaturel
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mnaturel
Copy link
Contributor

Steps to reproduce

When enabling LeakCanary, we see there is a missing call to clear the listeners in AudioMessagePlaybackTracker when the TimelineFragment is destroyed.

Outcome

What did you expect?

No memory leak.

What happened instead?

A memory leak is caught.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 28, 2022
@mnaturel mnaturel self-assigned this Jul 28, 2022
@mnaturel mnaturel changed the title [Timeline] - Memory leak in audio message playback tracker [Timeline] Memory leak in audio message playback tracker Jul 28, 2022
@mnaturel mnaturel mentioned this issue Jul 28, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Timeline] Memory leak in audio message playback tracker element-hq/element-android
1 participant
@mnaturel