Space Switching: Accordion-Style Bottom Sheet #6907
Conversation
ericdecanini
requested review from
ElementBot,
a team,
fedrunov and
bmarty
and removed request for
ElementBot,
a team and
fedrunov
| ) { | ||
| val host = this | ||
| newSpaceListHeaderItem { | ||
| id("space_list_header") | ||
| } |
There was a problem hiding this comment.
This is removed in another PR (#6877) so I didn't bother abstracting this
|
|
|
||
| override fun bind(holder: Holder) { | ||
| super.bind(holder) | ||
| holder.rootView.onClick(listener) | ||
| holder.root.onClick(onSpaceSelectedListener) | ||
| holder.root.setOnLongClickListener { onLongClickListener?.invoke(holder.root).let { true } } |
There was a problem hiding this comment.
.let { true } is maybe not useful. it is not used.
Having return true is probably better.
| android:src="@drawable/ic_arrow_right" | ||
| android:visibility="visible" | ||
| android:background="?selectableItemBackground" | ||
| android:contentDescription="@string/a11y_expand_space_children" |
There was a problem hiding this comment.
contentDescription has to be updated when the state is expanded.
|
SonarCloud Quality Gate failed. |
Type of change
Content
Changes the space sheet style back to accordion style as it is in the old app layout
Other not-so-obvious changes:
Motivation and context
Closes #6815
Screenshots / GIFs
Tests
Tested devices
Checklist