Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Layout - Adds missing space list header #7040

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Sep 6, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds the "CHANGE SPACE" header to the space list that got lost in a recent pr

Motivation and context

Part 1/2 of work for #7027

Screenshots / GIFs

image

Tests

Open the space list. See CHANGE SPACE header

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini added the PR-Small PR with less than 20 updated lines label Sep 6, 2022
@ericdecanini ericdecanini marked this pull request as ready for review September 6, 2022 13:53
@ericdecanini ericdecanini requested a review from bmarty September 6, 2022 13:53
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For a long term solution, it would be nice to create some more generic Epoxy Item. But maybe we will migrate to Jetpack compose eventually.

@bmarty
Copy link
Member

bmarty commented Sep 6, 2022

Also the string was removed by one of your commit 51ccd43 and all the existing translations has been removed because of that. They will be translated again, this is not a big deal. Not sure what happen 🤷‍♂️

@ericdecanini
Copy link
Contributor Author

Also the string was removed by one of your commit 51ccd43 and all the existing translations has been removed because of that. They will be translated again, this is not a big deal. Not sure what happen 🤷‍♂️

Design and development iterated together ✨

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ericdecanini ericdecanini merged commit da88b37 into develop Sep 7, 2022
@ericdecanini ericdecanini deleted the bugfix/eric/new-layout-missing-header branch September 7, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants