Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutualize the pending auth handling #7193

Closed
mnaturel opened this issue Sep 21, 2022 · 0 comments · Fixed by #7206
Closed

Mutualize the pending auth handling #7193

mnaturel opened this issue Sep 21, 2022 · 0 comments · Fixed by #7206
Assignees
@mnaturel
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

Your use case

What would you like to do?

Mutualize the process of pending auth handling.

Why would you like to do it?

Several ViewModel which need authentication for some actions duplicate the same code to handle the pending auth and action.

How would you like to achieve it?

Create a dedicated PendingAuthHandler to encapsulate the logic and add unit tests on it.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 21, 2022
@mnaturel mnaturel self-assigned this Sep 21, 2022
@mnaturel mnaturel mentioned this issue Sep 22, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mutualize the pending auth handling (PSG-742) element-hq/element-android
1 participant
@mnaturel