Add voice broadcast labs setting #7393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian14
changed the title
Florian14
changed the base branch from
develop
to
feature/fre/voice_broadcast_start_listening
Florian14
requested review from
a team and
ericdecanini
and removed request for
a team
Florian14
force-pushed
the
feature/fre/voice_broadcast_start_listening
branch
from
441001b to
d53ad43
Compare
Florian14
force-pushed
the
feature/fre/voice_broadcast_labs_flag
branch
from
8c323ee to
f8261c1
Compare
Florian14
added
the
Z-NextRelease
Florian14
requested review from
a team and
fedrunov
and removed request for
ericdecanini and
a team
Base automatically changed from
feature/fre/voice_broadcast_start_listening
to
develop
October 18, 2022 15:54
bmarty
approved these changes
Oct 18, 2022
| label = "Enable Voice Broadcast", | ||
| key = DebugFeatureKeys.voiceBroadcastEnabled, | ||
| factory = VectorFeatures::isVoiceBroadcastEnabled | ||
| ), |
There was a problem hiding this comment.
Adding a lab setting should not make us to remove the feature flag. The feature flag could help to control the display of the lab setting. Not blocking this PR though.
| --> | ||
|
|
||
| <!-- Level 1: Labs --> | ||
| <bool name="settings_labs_enable_voice_broadcast_visible">true</bool> |
There was a problem hiding this comment.
That's a nice solution, hence could be hard to understand for fork maintainers.
I would rather test API version in the code, to eventually hide the setting, even if the bool is set to true.
| @@ -49,6 +49,8 @@ | |||
| <bool name="settings_timeline_show_live_sender_info_default">false</bool> | |||
| <bool name="settings_labs_rich_text_editor_visible">true</bool> | |||
| <bool name="settings_labs_rich_text_editor_default">false</bool> | |||
| <bool name="settings_labs_enable_voice_broadcast_visible">false</bool> <!-- Note: also defined in values-v29 --> | |||
There was a problem hiding this comment.
If you keep this, I would rather comment like this:
Suggested change
| <bool name="settings_labs_enable_voice_broadcast_visible">false</bool> <!-- Note: also defined in values-v29 --> | |
| <bool name="settings_labs_enable_voice_broadcast_visible">false</bool> <!-- Note: this value must always be false. See in values-v29/config-settings to toggle the visibility of this flag. --> |
But I would definitely go for the test at runtime, to avoid any mistakes.
So this could be changed to
Suggested change
| <bool name="settings_labs_enable_voice_broadcast_visible">false</bool> <!-- Note: also defined in values-v29 --> | |
| <!-- Note: on device with API < 29, setting this value to true has no effect. --> | |
| <bool name="settings_labs_enable_voice_broadcast_visible">false</bool> |
giomfo
reviewed
Oct 18, 2022
added 8 commits
October 18, 2022 21:07
Florian14
force-pushed
the
feature/fre/voice_broadcast_labs_flag
branch
from
f8261c1 to
90803be
Compare
bmarty
reviewed
Oct 18, 2022
| @@ -3346,6 +3346,8 @@ | |||
| <string name="labs_enable_session_manager_summary">Have greater visibility and control over all your sessions.</string> | |||
| <string name="labs_enable_client_info_recording_title">Enable client info recording</string> | |||
| <string name="labs_enable_client_info_recording_summary">Record the client name, version, and url to recognise sessions more easily in session manager.</string> | |||
| <string name="labs_enable_voice_broadcast_title">Enable Voice broadcast (under active development)</string> | |||
| <string name="labs_enable_voice_broadcast_summary">Be able to record and send voice broadcast in room timeline.‡</string> | |||
There was a problem hiding this comment.
Looks like there is an extra ‡ at the end of the sentence.
changelog.d/7393.wip
Outdated
| @@ -0,0 +1 @@ | |||
| [Voice Broadcast] Move the feature flag to the labs | |||
There was a problem hiding this comment.
Suggested change
| [Voice Broadcast] Move the feature flag to the labs | |
| [Voice Broadcast] Enable the feature (behind a lab flag and only for Android 10 and up). |
giomfo
reviewed
Oct 18, 2022
| @@ -3346,6 +3346,8 @@ | |||
| <string name="labs_enable_session_manager_summary">Have greater visibility and control over all your sessions.</string> | |||
| <string name="labs_enable_client_info_recording_title">Enable client info recording</string> | |||
| <string name="labs_enable_client_info_recording_summary">Record the client name, version, and url to recognise sessions more easily in session manager.</string> | |||
| <string name="labs_enable_voice_broadcast_title">Enable Voice broadcast (under active development)</string> | |||
There was a problem hiding this comment.
@Florian14 feel free to replace the "Voice" with "voice". It would be more adapted to the other flags
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Remove the debug feature flag and move it to labs setting
Also renamed the recorded voice message files
Also changed the default voice messages duration
Note that the flag is not accessible on Android < 10 because the recording is not possible on these versions.
The flag only forbid voice broadcast recording but the listening is still possible for all users.
Motivation and context
Continue #7127
Screenshots / GIFs
Tests
Tested devices
Checklist