Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Fix duplicated chunks in the internal playlist during live broadcasts #7502

Merged

Conversation

Florian14
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Sometimes the playlist of voice messages contains duplicated sequences, this PR adds a distinct filter on the sequence number when fetching the playlist to prevent this case.

Motivation and context

Fix a bug when listening to a live voice broadcast, not sure it can perturb the listening.

Screenshots / GIFs

Tests

Tested by debugging a live broadcast where I observed an issue on the computed duration in #7494

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 changed the base branch from develop to resilience-rc November 1, 2022 17:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 requested review from a team and mnaturel and removed request for a team November 2, 2022 08:39
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Florian14 Florian14 merged commit dac89ad into resilience-rc Nov 2, 2022
@Florian14 Florian14 deleted the bugfix/fre/voice_broadcast_duplicated_chunks branch November 2, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants