Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications toggle: align implementation for current session #7512

Closed
mnaturel opened this issue Nov 2, 2022 · 0 comments · Fixed by #7523
Closed

Push notifications toggle: align implementation for current session #7512

mnaturel opened this issue Nov 2, 2022 · 0 comments · Fixed by #7523
Assignees
@mnaturel
Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Nov 2, 2022 •
edited
Loading

Your use case

What would you like to do?

Review and align the implementation of the logic to toggle the push notifications of the current session from "Settings -> Notifications".

Why would you like to do it?

To be consistent with what has been done in new Session manager screens.

How would you like to achieve it?

Introducing some use cases.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Settings labels Nov 2, 2022
@mnaturel mnaturel self-assigned this Nov 2, 2022
@mnaturel mnaturel mentioned this issue Nov 4, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
1 participant
@mnaturel