Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Fix keyboard closing after collapsing rich text editor #7659

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Nov 29, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix keyboard closing after collapsing rich text editor.

Motivation and context

https://element-io.atlassian.net/browse/PSU-994

When enabling the full-screen mode of the rich text editor, the keyboard should be opened. However, when collapsing, the keyboard should not be closed if it is already open.

Screenshots / GIFs

expand-collapse-keyboard.webm

Tests

  1. Enable the rich text editor via labs
  2. Navigate to a room
  3. Expand the text input
  4. Check the keyboard is opened
  5. Collapse the text input
  6. Check the keyboard is closed

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew force-pushed the fix/PSU-994-rich-text-fullscreen-keyboard branch from 670a9bb to 25a583b Compare November 29, 2022 13:30
@jonnyandrew jonnyandrew marked this pull request as ready for review November 29, 2022 13:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew requested review from a team and Florian14 and removed request for a team November 29, 2022 14:17
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyandrew jonnyandrew merged commit da5db0e into develop Dec 1, 2022
@jonnyandrew jonnyandrew deleted the fix/PSU-994-rich-text-fullscreen-keyboard branch December 1, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants