Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download device keys for self prior to verification checks #7699

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented Dec 2, 2022

Fixes #7676

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Hugh Nimmo-Smith [email protected]

@ElementBot
Copy link

Fails
🚫

Please add a sign-off to either the PR description or to the commits themselves. See instructions here.

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 79fa14e

@hughns hughns marked this pull request as ready for review December 6, 2022 11:34
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against f30f1b9

@hughns hughns requested a review from bmarty December 6, 2022 11:36
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark.

@hughns hughns requested a review from bmarty December 7, 2022 15:11
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hughns hughns enabled auto-merge December 8, 2022 10:29
@hughns hughns force-pushed the bugfix/hughns/qr-device-race branch from b9c5559 to 7bbd91f Compare December 8, 2022 13:27
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 7bbd91f

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hughns hughns merged commit a762179 into develop Dec 9, 2022
@hughns hughns deleted the bugfix/hughns/qr-device-race branch December 9, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition for sign in with QR preventing cross signing set up
3 participants