New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not propagate failure if saving the filter server side fails #7725

Merged

bmarty merged 2 commits into develop from feature/bma/filterCrash

Dec 7, 2022

Member

bmarty commented Dec 6, 2022

Uploading will be retried later.

Type of change

Feature
Bugfix
Technical
Other :

Content

Ignore errors when uploading the filter to the server. The SDK will not get a filterId, so will try to upload again later.

Motivation and context

Fixes #7720

Screenshots / GIFs

Tests

Start the app in airplane mode and observe that there is no crash anymore.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()


          Do not propagate failure if saving the filter server side fails. This…

ae93c07

… will be retried later.

bmarty added the Z-NextRelease label

bmarty requested a review from fedrunov

December 6, 2022 14:06

ElementBot commented Dec 6, 2022

	Warnings
⚠️	Please add a changelog. See instructions here

Generated by 🚫 dangerJS against ae93c07

fedrunov approved these changes

View reviewed changes

Contributor

fedrunov left a comment

LGTM


          Changelog

11dded7

bmarty merged commit 4a5f484 into develop

bmarty deleted the feature/bma/filterCrash branch

December 7, 2022 12:54

ElementBot commented Dec 7, 2022

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 11dded7

sonarqubecloud bot commented Dec 7, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels