Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the player timeline #7821

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Replace the player timeline #7821

merged 2 commits into from
Dec 22, 2022

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Dec 19, 2022

image

@yostyle yostyle requested review from jmartinesp and giomfo December 19, 2022 18:18
@ElementBot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 31540e6

jmartinesp
jmartinesp approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor suggestion.

.../im/vector/app/features/home/room/detail/timeline/item/MessageVoiceBroadcastListeningItem.kt Outdated Show resolved Hide resolved
giomfo
giomfo approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX review / Tests ok
@yostyle approved, please add a changelog file

@yostyle yostyle self-assigned this Dec 21, 2022
@yostyle yostyle added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Voice Broadcast Broadcast-style voice messages labels Dec 21, 2022
@yostyle yostyle changed the title [Voice Broadcast] Replace the player timeline Replace the player timeline Dec 21, 2022
@yostyle yostyle force-pushed the yostyle/add_voicebroadcast_timers branch from 31540e6 to 8eef57d Compare December 21, 2022 13:19
@yostyle
Copy link
Contributor Author

yostyle commented Dec 21, 2022

UX review / Tests ok @yostyle approved, please add a changelog file

added

@yostyle yostyle enabled auto-merge (squash) December 21, 2022 13:21
@ElementBot
Copy link

Fails
🚫

Invalid extension for changelog. See instructions here
Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 8eef57d

@yostyle yostyle disabled auto-merge December 21, 2022 13:21
@yostyle yostyle force-pushed the yostyle/add_voicebroadcast_timers branch from 8eef57d to 5452168 Compare December 21, 2022 13:23
@yostyle yostyle enabled auto-merge (squash) December 21, 2022 13:24
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 5452168

@yostyle yostyle force-pushed the yostyle/add_voicebroadcast_timers branch from 5452168 to a7f4df9 Compare December 22, 2022 12:57
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against a7f4df9

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle merged commit 92ed663 into develop Dec 22, 2022
@yostyle yostyle deleted the yostyle/add_voicebroadcast_timers branch December 22, 2022 14:05
@ghost ghost mentioned this pull request Dec 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees

@yostyle yostyle

Labels
A-Voice Broadcast Broadcast-style voice messages T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yostyle @ElementBot @jmartinesp @giomfo