Do not send any request to Posthog if no consent is provided.

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Ensure we never call posthog.identify if user did not consent, because it sends request <server>/decide/?v=2 to the analytic server.

Despite the fact that posthog.optout(true) has been called and no analytics is sent when the user has opt-out, calling posthog.identify trigger a request to the analytics server. We may consider this as a bug in the library itself, but in the mean time, this PR prevent calling posthog.identify is user consent is not set to true.

Motivation and context

Closes #8020

Screenshots / GIFs

Tests

• Add a breakpoint to Posthog::identify and ensure that it's never called when analytics consent is not provided, for instance when the application is started.
• Breakpoints can also be put in com.posthog.android.ConnectionFactory.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[yostyle]

LGTM

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

57.8% Coverage
0.0% Duplication