Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build unmerged APKs on pull request #8044

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Jan 31, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When building APKs for pull requests, build from the unmerged source.

Note that test jobs continue to build from merged source in order to reduce the chance of breaking the CI after merging.

Motivation and context

  • When testers test unmerged features built from pull requests, they should expect to test the same code that developers are working on in their development branch.
  • Repeated builds of the same PR branch should result in the same binary.

CI logs

From the build of 9f10c49

Checking out the ref
  /usr/bin/git checkout --progress --force 9f10c49bd8f6571fc470c2bae974f97aafb9717b

  HEAD is now at 9f10c49 Build unmerged APKs on pull request
/usr/bin/git log -1 --format='%H'
'9f10c49bd8f6571fc470c2bae974f97aafb9717b'

Tests

N/A

Tested devices

N/A

Checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew marked this pull request as ready for review February 6, 2023 13:39
@jonnyandrew jonnyandrew requested review from a team and ganfra and removed request for a team February 6, 2023 13:39
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense, thanks. Should probably apply for EAX too

@jonnyandrew jonnyandrew merged commit a8ba3aa into develop Feb 16, 2023
@jonnyandrew jonnyandrew deleted the ci/apk-build-for-pr branch February 16, 2023 16:49
@bmarty
Copy link
Member

bmarty commented Feb 16, 2023

I will do it in the context of element-hq/element-x-android#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants