Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline]: Editing a reply from iOS breaks the "in reply to" rendering #8150

Closed
mnaturel opened this issue Feb 20, 2023 · 1 comment · Fixed by #8151
Closed

[Timeline]: Editing a reply from iOS breaks the "in reply to" rendering #8150

mnaturel opened this issue Feb 20, 2023 · 1 comment · Fixed by #8151
Assignees
@mnaturel
Labels
A-Replies O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mnaturel
Copy link
Contributor

Steps to reproduce

From iOS client:

  • Reply to a message
  • Edit the reply

Outcome

What did you expect?

We should see the edited reply still rendering as a "in reply to" message.

What happened instead?

After the reply message has been edited, the "in reply to" message is considered as a simple text message and the "in reply to" context is lost.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Replies S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 20, 2023
@mnaturel mnaturel self-assigned this Feb 20, 2023
@mnaturel mnaturel mentioned this issue Feb 20, 2023
Merged
15 tasks
@HarHarLinks
Copy link
Contributor

while you could patch that, what really needs to be done is #3731 (on iOS too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Replies O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
2 participants
@HarHarLinks @mnaturel