Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom push gateway to use non-default port #8376

Merged
merged 2 commits into from
May 2, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Apr 28, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Allow a custom push gateway to use a non-default port

Motivation and context

When a custom UnifiedPush push gateway is detected, it's gateway URL is constructed from URL components contained within the push key. However, if the gateway URL contains a custom port, this is ignored and the push gateway test fails.

Screenshots / GIFs

image

Tests

  • Set up a custom push gateway which uses a custom port
  • Go to settings > notifications > troubleshoot

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew force-pushed the jonny/fix/custom-push-gateway-port branch from 874b463 to a121115 Compare April 28, 2023 10:12
@jonnyandrew jonnyandrew requested review from MatMaul, a team and Florian14 and removed request for a team April 28, 2023 10:53
@jonnyandrew jonnyandrew marked this pull request as ready for review April 28, 2023 10:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Could be awesome if you create a PR for the same fix on ElementX.

Thanks!

@jonnyandrew jonnyandrew merged commit e37fe1f into develop May 2, 2023
@jonnyandrew jonnyandrew deleted the jonny/fix/custom-push-gateway-port branch May 2, 2023 10:05
@jonnyandrew
Copy link
Contributor Author

Could be awesome if you create a PR for the same fix on ElementX.

@bmarty, no problem, here it is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants