Remove legacy manually verify specific other device #8458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
May 22, 2023
| @@ -69,7 +68,7 @@ class DeviceListBottomSheetViewModel @AssistedInject constructor( | |||
| val session = EntryPoints.get(viewModelContext.app(), SingletonEntryPoint::class.java).activeSessionHolder().getActiveSession() | |||
| return DeviceListViewState( | |||
| userId = userId, | |||
| allowDeviceAction = args.allowDeviceAction, | |||
| myUserId = session.myUserId, | |||
There was a problem hiding this comment.
Not a blocker, but maybe also remove DeviceListBottomSheet.Args::allowDeviceAction
| @@ -22,6 +22,8 @@ import org.matrix.android.sdk.api.session.crypto.model.RoomEncryptionTrustLevel | |||
| // TODO Replace usage by the use case GetEncryptionTrustLevelForDeviceUseCase | |||
| object TrustUtils { | |||
|
|
|||
| // XXX why is this using the RoomEncryptionTrustLevel? | |||
| // should be using a new DeviceTrustShield enum | |||
BillCarsonFr
force-pushed
the
feature/bca/remove_legacy_per_device_verif
branch
from
65d6296 to
bb59a75
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
In the member profile it was possible to manually verify a specific device of a given user. This is will perform a verification to mark this device as locally verified, but local verificaiton is not considered anymore in UI, so the device will not pass to a green shield after that (it's passing to a shield with a question mark now (?), this should be changed as part of another PR).
Devices of other users are the responsability of other users, on your side you should verify the user and let him verifiy its devices.
The UI to perform this action is removed by this PR.
If you want to verify your own device you should go to settings.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist