Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable E2EE by default #257

Closed
ara4n opened this issue Mar 6, 2022 · 0 comments · Fixed by #337
Closed

Enable E2EE by default #257

ara4n opened this issue Mar 6, 2022 · 0 comments · Fixed by #337
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Mar 6, 2022

This is a tracking issue for turning on E2EE by default. This means merging matrix-org/matrix-js-sdk#2002 and then using it for todevice signalling in element-call.

In practice, I think can go ahead and do this without further delay, because:

  • I am confident that todevice messaging (at least between users on the same server) is robust on Synapse, having tortured it with https://github.com/ara4n/todevice-collider
  • The rageshake reporting operates in terms of unencrypted messages, so we should be able to debug irrespective of E2EE assuming that to-device is working okay.
  • Even if we do see to-device messages disappearing on the server, we can chase them through as opaque blobs anyway.

However, it's worth noting that E2EE is useless without verification. As a first cut we could do TOFU and persist the verification state in localstorage, but obviously this will not help us with a preexisting attack or impersonator, which would be pretty easy, not least given we're currently spinning up new user IDs everywhere rather than inheriting existing trust. I'll file a separate bug for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant