Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key bind to fix inconsistent usage between slider elements #1002

Closed
Half-and-Xat opened this issue Jun 7, 2023 · 12 comments
Closed

Add key bind to fix inconsistent usage between slider elements #1002

Half-and-Xat opened this issue Jun 7, 2023 · 12 comments
Labels

Comments

@Half-and-Xat
Copy link

Half-and-Xat commented Jun 7, 2023

Steps to reproduce

  1. Using a touch screen device - in my case Librem 5 (haven't tested others, but should be same issue).
  2. Start Element and log into account.
  3. Try to scroll text via right scrollbar or to horizontal slide (resize) between room panel and text panel.

Outcome

It should be able to scroll or resize things. But nothing happens because the long touch is like a long pressed right mouse button. While I can use right or left click inside the room panel to hide rooms via vertical slider below the list, the 2 things I wrote above only work with long left click. The ability to drag with both mouse buttons would solve that issue and breaks nothing as far as I can see.

Scrolling is not so important since we can scroll via touch-and-drag the text panel, but it is still confusing with scroll bar. Resizing horizontal the room panel is important to get the space on small devices like on Librem 5 or Pinephone Pocket PCs.

I don't see any other issue with touchscreen on mobile Linux yet.

Operating system

PureOS Byzantium (Debian Buster)

Application version

Element: 1.11.32; Olm: 3.2.14

How did you install the app?

https://element.io/download#linux

Homeserver

No response

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

See https://github.com/vector-im/element-web/#supported-environments

Mobile devices such as the Librem 5 are not in the support policy, sorry. I suggest tacking onto the existing element-web scaling & touch issues.

@t3chguy t3chguy closed this as completed Jun 7, 2023
@Half-and-Xat
Copy link
Author

It is a desktop operating system (Debian). PureOS is a made for convergence between large and little screens as well as mouse inputs and touch inputs. Everything works as expected as on laptop or tower PC. I know apps that doesn't even fit on smaller screens. Element desktop fits perfect, because resizing is completely implemented. The goal of this devices is to take desktop PC with you in your pocket ... not to become a smartphone where you have to rebuild and recompile apps.

And you say you don't want to add that additional input just because this desktop can be put in a trouser? You cut a growing community away just for that reason. Element Web works not as good as Element desktop in the current stage, because of the browser overhead and all its downsides. Please, think about it.

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

@Half-and-Xat selective reading won't help anyone here

for desktop devices

Common reading of the above

It simply isn't a focus of the Element Web & Desktop apps at this time, we don't have enough developers to support everything, though as always; contributions are welcome to improve support for things like touch devices.

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

element-hq/element-web#8735 is the Element Web issue around touch I pointed you to earlier

@Half-and-Xat
Copy link
Author

That is a different thing I don't care a lot. For me buttons are big enough. It seams that I haven't explained well enough, because it's about key bindings.

It's about that: you already have implemented the left or right click and drag on one element (hiding rooms) and not on other elements. It is a inconsistent design if you ask me (game designer, not programmer - else I would fix it by my own). It's may more relevant for touch screen devices, but it's also an inner design issue. At least there is not much "support" needed, just 1 other (but similar) input method for same event. As game designer I cannot program it, but I understand enough to know that this is not much work and don't add much complexity. It's "just" an additional key bind.

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

The issue title is the important bit here, not their specific ask, I suggest tacking onto it, the product team would handle touch support as a concept not as little subtasks, as a whole it isn't prioritised atm in favour of focus on the dedicated mobile apps (which doesn't help you much)

@Half-and-Xat Half-and-Xat changed the title Drag issues on touch devices Add key bind to fix inconsistent usage between slider elements Jun 7, 2023
@Half-and-Xat
Copy link
Author

Better?

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

Or maybe you want element-hq/element-web#13526

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

@Half-and-Xat this isn't an element-desktop issue, we don't do any input event handling specific to desktop, we levy React in element-web to do that for us, Element Desktop just wraps it in Electron. Hence pushing you to reuse an existing open issue in Element Web about lacking Touch Support, keep in mind the support policy says any issues reported for unsupported devices get immediately closed.

@Half-and-Xat
Copy link
Author

Half-and-Xat commented Jun 7, 2023

So if Web fixes it, you also will have it a bit later? If this is true - sorry for taking your time, I will open that issue there (if there is none).

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2023

Element Desktop is Element Web + Electron + Keytar + Seshat, so if Element Web fixes it then Element Desktop will have the fix in the exact same release. I suggest adding detail to element-hq/element-web#13526 rather than opening a new issue otherwise it'll get closed as a duplicate of a broader issue (about touch support in general)

@Half-and-Xat
Copy link
Author

Okay thanks for that advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants