From ee2623906a904cd9e25dce3c3418a5d183854b18 Mon Sep 17 00:00:00 2001 From: Alfonso Grillo Date: Wed, 26 Apr 2023 15:36:29 +0200 Subject: [PATCH 1/3] Fix accessibility in SetPinCoordinatorBridgePresenter --- .../Modules/SetPinCode/SetPinCoordinatorBridgePresenter.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Riot/Modules/SetPinCode/SetPinCoordinatorBridgePresenter.swift b/Riot/Modules/SetPinCode/SetPinCoordinatorBridgePresenter.swift index c381b76eb7..6c4e69d147 100644 --- a/Riot/Modules/SetPinCode/SetPinCoordinatorBridgePresenter.swift +++ b/Riot/Modules/SetPinCode/SetPinCoordinatorBridgePresenter.swift @@ -91,6 +91,10 @@ final class SetPinCoordinatorBridgePresenter: NSObject { } func presentWithMainAppWindow(_ window: UIWindow) { + // Prevents the VoiceOver reading accessible content when the PIN screen is on top + // Calling `makeKeyAndVisible` in `dismissWithMainAppWindow(_:)` restores the visibility state. + window.isHidden = true + let pinCoordinatorWindow = UIWindow(frame: window.bounds) let setPinCoordinator = SetPinCoordinator(session: self.session, viewMode: self.viewMode, pinCodePreferences: .shared) From 2f5d1799fb540af382e5bea162b27e3a1b97fbcb Mon Sep 17 00:00:00 2001 From: Alfonso Grillo Date: Wed, 26 Apr 2023 15:46:43 +0200 Subject: [PATCH 2/3] Remove accessibility from placeholder button --- .../EnterPinCodeViewController.storyboard | 61 +++++++++++-------- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/Riot/Modules/SetPinCode/EnterPinCode/EnterPinCodeViewController.storyboard b/Riot/Modules/SetPinCode/EnterPinCode/EnterPinCodeViewController.storyboard index e3f675ca60..ab5ef64829 100644 --- a/Riot/Modules/SetPinCode/EnterPinCode/EnterPinCodeViewController.storyboard +++ b/Riot/Modules/SetPinCode/EnterPinCode/EnterPinCodeViewController.storyboard @@ -1,26 +1,27 @@ - + - + + - + - + @@ -44,20 +45,20 @@ - + @@ -97,7 +98,7 @@ - + @@ -106,7 +107,7 @@ - + @@ -124,12 +125,12 @@ - + - - - - - - - - - + @@ -312,6 +316,7 @@ + @@ -323,7 +328,6 @@ - @@ -350,5 +354,8 @@ + + + From fda718396982b3965f8969e920af40b48942bceb Mon Sep 17 00:00:00 2001 From: Alfonso Grillo Date: Wed, 26 Apr 2023 15:55:19 +0200 Subject: [PATCH 3/3] Add changelog.d file --- changelog.d/pr-7522.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/pr-7522.bugfix diff --git a/changelog.d/pr-7522.bugfix b/changelog.d/pr-7522.bugfix new file mode 100644 index 0000000000..0bd4e5b530 --- /dev/null +++ b/changelog.d/pr-7522.bugfix @@ -0,0 +1 @@ +Fix accessibility when entering the PIN to unlock the app.